Re: New pkg geography/viking

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Tue, Feb 17, 2009 at 05:22:46PM +0100, Jochen Kunz wrote:
> I created a new pkg geography/viking. As I have cvs commit privileges I
> could just commit it. But I haven't done any pkgsrc work before.
> Therefore I would like to get a review from an experienced pkgsrc guru
> first: http://www.unixag-kl.fh-kl.de/~jkunz/tmp/viking-pkgsrc.tar.gz

USE_TOOLS has build dependency as default, so no need to specify it.

Please sort the includes, bsd.pkg.mk being last.

No BUILD_MAKE_FLAGS for parallel building as default please.

COMMENT is too long.

Consistent vertical alignment of the values would be a nice bonus.

The DEPENDS is incorrect, it must specify a pattern, e.g.
gpsbabel-[0-9]*:../../geography/gpsbabel

You are very likely missing msgfmt as tool and devel/gettext-libs as
include for libintl.

JoerG