trafshow borken, due too a missing pcap_version (was: CVS commit: src)

[Bernd Ernesti <netbsd%lists.veego.de@localhost>]

Hi,

I get the following error while compiling pkgsrc/net/trafshow:

cc -O2 -I/usr/include -Wall -I. -DHAVE_CONFIG_H  -pthread -L/usr/lib 
-Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -o trafshow trafshow.o screen.o colormask.o 
getkey.o selector.o events.o session.o show_if.o show_stat.o show_dump.o 
parse_dl.o parse_ip.o netstat.o cisco_netflow.o addrtoname.o hashtab.o 
lookupa.o recycle.o util.o help_page.o domain_resolver.o   version.o -lcurses 
-ltermcap -lpcap -lresolv
trafshow.o: In function `vers':
trafshow.c:(.text+0x105e): undefined reference to `pcap_version'
*** Error code 1

First I tried to update trafshow to 5.2.3, but this didn't fix that problem.

Hmm, there is the following Makefile rule in src/dist/libpcap/Makefile.in:

version.c: $(srcdir)/VERSION
        @rm -f $@
        sed -e 's/.*/char pcap_version[] = "&";/' $(srcdir)/VERSION > $@

But I can't find any code which would do the same in src/lib/libpcap/Makefile

IMHO we have to add this version info back into libpcap.so.

Bernd

On Tue, Apr 25, 2006 at 06:36:45PM +0000, Matthias Drochner wrote:
> 
> Module Name:  src
> Committed By: drochner
> Date:         Tue Apr 25 18:36:45 UTC 2006
> 
> Modified Files:
>       src/distrib/sets/lists/base: shl.elf shl.mi
>       src/lib/libpcap: Makefile shlib_version version.h
>       src/usr.sbin/pf/pflogd: Makefile
> Added Files:
>       src/lib/libpcap: config.h
> Removed Files:
>       src/lib/libpcap: CHANGES README atmuni31.h bpf_dump.c bpf_image.c
>           etherent.c ethertype.h fad-getad.c gencode.c gencode.h grammar.y
>           inet.c llc.h nametoaddr.c nlpid.h optimize.c pcap-bpf.c pcap-int.h
>           pcap-namedb.h pcap.3 pcap.c pcap.h pcap2netbsd ppp.h savefile.c
>           scanner.l sll.h sunatmpos.h version.c
> 
> Log Message:
> Build libpcap-0.9.4 from src/dist.
> While there are some open issues, particulary wrt support of old
> NetBSD-specific interfaces, it is better to get the code some public
> testing before NetBSD-4 is branched.