Re: CVS commit: pkgsrc

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Fri, May 01, 2020 at 06:42:32AM +0000, Roland Illig wrote:
> Module Name:  pkgsrc
> Committed By: rillig
> Date:         Fri May  1 06:42:32 UTC 2020
> 
> Modified Files:
>       pkgsrc/mk: subst.mk
>       pkgsrc/regress/infra-unittests: subst.sh
> 
> Log Message:
> mk/subst.mk: switch command substitution back to backticks
> 
> To work properly, the $(...) should have been $$(...).
> 
> In pkgsrc the command substitution is usually done via `backticks`, for
> compatibility with /bin/sh from Solaris.  To fix the shell parse errors,
> the special characters are properly escaped inside the command
> substitution.

You know, I even gave you a test case for where the original code fails.
Why don't you try fixing that instead of blindly reverting other
people's changes?

Joerg