On 06.10.2017 16:17, Jonathan Perkin wrote:
> * On 2017-10-06 at 15:01 BST, coypu%sdf.org@localhost wrote:
>
>> It is fixing a real issue. the build is broken on linux.
>
> I think the general point is that if you're fixing something for a
> specific system (the bulk build reports show that this isn't showing
> up anywhere else, not even latest Ubuntu) then it should be limited to
> that specific system, unless you are extremely confident it won't
> break even our most esoteric supported platform.
>
Here is a breakage reproduced on FreeBSD:
clang++ -I/usr/include -D_REENTRANT -DU_HAVE_ELF_H=1 -DU_HAVE_ATOMIC=1
-DU_HAVE_TIMEZONE=0 -DU_HAVE_STRTOD_L=1 -I. -I../common
-DU_ATTRIBUTE_DEPRECATED= -DU_I18N_IMPLEMENTATION -O2 -I/usr/include -W
-Wall -pedantic -Wpointer-arith -Wwrite-strings -Wno-long-long
-std=c++11 -Qunused-arguments -Wno-parentheses-equality -c -o
digitlst.ao digitlst.cpp
digitlst.cpp:529:12: error: use of undeclared identifier 'strtod_l'
return strtod_l(decstr, end, gCLocale);
^
1 error generated.
../config/mh-bsd-gcc:43: recipe for target 'digitlst.ao' failed
gmake[1]: *** [digitlst.ao] Error 1
gmake[1]: Leaving directory
'/usr/home/kamil/pkgsrc/textproc/icu/work/icu/source/i18n'
Makefile:147: recipe for target 'all-recursive' failed
gmake: *** [all-recursive] Error 2
*** Error code 2
Stop.
bmake[1]: stopped in /usr/home/kamil/pkgsrc/textproc/icu
*** Error code 1
Stop.
bmake: stopped in /usr/home/kamil/pkgsrc/textproc/ic
Attachment:
signature.asc
Description: OpenPGP digital signature