Re: CVS commit: pkgsrc/textproc/icu

[coypu%sdf.org@localhost]

On Fri, Oct 06, 2017 at 11:56:01AM +0200, Kamil Rytarowski wrote:
> On 06.10.2017 00:50, Maya Rashish wrote:
> > Module Name:        pkgsrc
> > Committed By:       maya
> > Date:               Thu Oct  5 22:50:30 UTC 2017
> > 
> > Modified Files:
> >     pkgsrc/textproc/icu: distinfo
> >     pkgsrc/textproc/icu/patches: patch-i18n_digitlst.cpp
> > 
> > Log Message:
> > icu: never include xlocale.h, always use locale.h
> > 
> > This was a glibc header, whereas locale.h is a POSIX one.
> > glibc went ahead and removed it in the new version.
> > 
> > change suggested by Thomas Orgis on tech-pkg but probably not applied
> > exactly.
> > 
> > 
> 
> 
> xlocale.h is not just glibc header, it's required to be included before
> other headers on FreeBSD, Darwin etc in order to get _l functions available.
> 


I was basing myself on glibc 2.26 release notes :-)
https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27xlocale.h.27

"The nonstandard header xlocale.h has been removed in this release. It
was never intended to be included directly by programs other than glibc
itself, and it was a strict subset of the standard header locale.h. We
know that a number of programs do include it, but because it has never
been part of any other C library, programs that use it are probably
testing for its existence with autoconf or a similar tool, and should
not fail to compile. "