pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/mk/extract mk/extract/extract.mk: enclose extract_file...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/58b159ff820b
branches:  trunk
changeset: 425195:58b159ff820b
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Fri Mar 20 15:00:45 2020 +0000

description:
mk/extract/extract.mk: enclose extract_file in quotes

This prevents unintended shell word expansion.

It also makes that argument visible in "bmake show-all-extract". Before,
it was left out entirely from the output. Now it is printed as an empty
string literal, which at least gives a hint that "there is something".

diffstat:

 mk/extract/extract.mk |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (18 lines):

diff -r f1b5f0240660 -r 58b159ff820b mk/extract/extract.mk
--- a/mk/extract/extract.mk     Fri Mar 20 14:40:56 2020 +0000
+++ b/mk/extract/extract.mk     Fri Mar 20 15:00:45 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: extract.mk,v 1.40 2020/03/14 00:14:35 gdt Exp $
+# $NetBSD: extract.mk,v 1.41 2020/03/20 15:00:45 rillig Exp $
 #
 # The following variables may be set by the package Makefile and
 # specify how extraction happens:
@@ -210,7 +210,7 @@
 
 EXTRACT_CMD?=  ${EXTRACT_CMD_DEFAULT}
 
-DOWNLOADED_DISTFILE=   $${extract_file}
+DOWNLOADED_DISTFILE=   "$${extract_file}"
 
 .if !target(do-extract)
 do-extract: ${WRKDIR}



Home | Main Index | Thread Index | Old Index