pkgsrc-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[pkgsrc/trunk]: pkgsrc/chat/xchat chat/xchat: fix YAGNI code for GCONF_SCHEMAS
details: https://anonhg.NetBSD.org/pkgsrc/rev/4d9cee24c72b
branches: trunk
changeset: 388803:4d9cee24c72b
user: rillig <rillig%pkgsrc.org@localhost>
date: Fri Dec 14 21:35:43 2018 +0000
description:
chat/xchat: fix YAGNI code for GCONF_SCHEMAS
The loop would not have worked with multiple GCONF_SCHEMAS anyway because
there was no semicolon at the end of the @.s.@ expansion. Since
INSTALL_DATA can handle multiple source arguments, there is no need to
use the complicated form.
diffstat:
chat/xchat/Makefile | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diffs (23 lines):
diff -r a3c8b8b83f56 -r 4d9cee24c72b chat/xchat/Makefile
--- a/chat/xchat/Makefile Fri Dec 14 17:29:32 2018 +0000
+++ b/chat/xchat/Makefile Fri Dec 14 21:35:43 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.108 2018/11/14 22:21:09 kleink Exp $
+# $NetBSD: Makefile,v 1.109 2018/12/14 21:35:43 rillig Exp $
.include "Makefile.common"
@@ -49,11 +49,9 @@
${DESTDIR}${PREFIX}/include/xchat/
.if !empty(PKG_OPTIONS:Mgnome)
-
${INSTALL_DATA_DIR} ${DESTDIR}${GCONF_SCHEMAS_DIR}
-# In case there're ever additional schema files, use ODE loop.
- ${GCONF_SCHEMAS:@.s.@${INSTALL_DATA} ${WRKSRC}/src/common/dbus/${.s.} \
- ${DESTDIR}${GCONF_SCHEMAS_DIR}/@}
+ cd ${WRKSRC}/src/common/dbus \
+ && ${INSTALL_DATA} ${GCONF_SCHEMAS} ${DESTDIR}${GCONF_SCHEMAS_DIR}/
.endif
.include "../../mk/bsd.pkg.mk"
Home |
Main Index |
Thread Index |
Old Index