[pkgsrc/trunk]: pkgsrc/graphics/libimagequant Don't put configure scratch fil...

[dholland <dholland%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/35395e7408af
branches:  trunk
changeset: 372912:35395e7408af
user:      dholland <dholland%pkgsrc.org@localhost>
date:      Wed Dec 20 11:52:23 2017 +0000

description:
Don't put configure scratch files in /tmp; it isn't safe and also might
fail for extraneous reasons.

diffstat:

 graphics/libimagequant/distinfo                |   4 ++--
 graphics/libimagequant/patches/patch-configure |  21 ++++++++++++++++-----
 2 files changed, 18 insertions(+), 7 deletions(-)

diffs (66 lines):

diff -r 9c79e1dd2186 -r 35395e7408af graphics/libimagequant/distinfo
--- a/graphics/libimagequant/distinfo   Wed Dec 20 11:08:06 2017 +0000
+++ b/graphics/libimagequant/distinfo   Wed Dec 20 11:52:23 2017 +0000
@@ -1,8 +1,8 @@
-$NetBSD: distinfo,v 1.11 2017/11/28 10:35:27 adam Exp $
+$NetBSD: distinfo,v 1.12 2017/12/20 11:52:23 dholland Exp $
 
 SHA1 (libimagequant-2.11.4.tar.gz) = 4ff6e1168b2526c9ea3761249ecd31b95c062750
 RMD160 (libimagequant-2.11.4.tar.gz) = c4009437c1d4a9e58719248f141541df97aa56d6
 SHA512 (libimagequant-2.11.4.tar.gz) = e9d2aaac2f37968dc93ba0da7d03f0fcf60b3f17d9a0b9edfd6930eade25844dd603de74492d8e1de8dc2da4e7f3e47959a558b5a67588d71e9e1db035eca1cc
 Size (libimagequant-2.11.4.tar.gz) = 74117 bytes
 SHA1 (patch-Makefile) = 78a77b6348c3a254164cbbb2c8e2c3d000c10d10
-SHA1 (patch-configure) = 747b121b901dff19374999c543ea7cb361c25428
+SHA1 (patch-configure) = 4425589a1956f4c4303370baceb605308f07edf0
diff -r 9c79e1dd2186 -r 35395e7408af graphics/libimagequant/patches/patch-configure
--- a/graphics/libimagequant/patches/patch-configure    Wed Dec 20 11:08:06 2017 +0000
+++ b/graphics/libimagequant/patches/patch-configure    Wed Dec 20 11:52:23 2017 +0000
@@ -1,8 +1,9 @@
-$NetBSD: patch-configure,v 1.5 2017/07/03 21:50:32 adam Exp $
+$NetBSD: patch-configure,v 1.6 2017/12/20 11:52:23 dholland Exp $
 
 Remove unwanted compiler flags.
+Avoid leaving scratch files in /tmp.
 
---- configure.orig     2017-07-02 21:40:53.000000000 +0000
+--- configure.orig     2017-11-27 15:38:43.000000000 +0000
 +++ configure
 @@ -2,7 +2,7 @@
  
@@ -13,7 +14,17 @@
  
  DEBUG=
  QUIET=0
-@@ -136,7 +136,7 @@ cflags "-std=c99 -I."
+@@ -124,7 +124,8 @@ if [ "$QUIET" -ne 1 ]; then
+ fi
+ 
+ # /tmp, because mingw has problems opening /dev/null and gives false negative
+-if ! echo "int main(){}" | "$CC" -xc -std=c99 -o /tmp/gcccheck - > /dev/null; then
++# not /tmp, because that's not safe
++if ! echo "int main(){}" | "$CC" -xc -std=c99 -o ./tmp-gcccheck - > /dev/null; then
+     error "Compiler" "$CC failed to compile anything (make sure it's installed and supports C99)"
+ fi
+ 
+@@ -136,7 +137,7 @@ cflags "-std=c99 -I."
  
  # DEBUG
  if [ -z "$DEBUG" ]; then
@@ -22,7 +33,7 @@
      status "Debug" "no"
  else
      cflags "-O1 -g"
-@@ -174,15 +174,9 @@ if [ -n "$OPENMP" ]; then
+@@ -174,15 +175,9 @@ if [ -n "$OPENMP" ]; then
      else
          OPENMPFLAGS="-fopenmp"
      fi
@@ -38,7 +49,7 @@
  else
      # silence warnings about omp pragmas
      cflags "-Wno-unknown-pragmas"
-@@ -190,20 +184,10 @@ else
+@@ -190,20 +185,10 @@ else
      status "OpenMP" "no"
  fi