[pkgsrc/trunk]: pkgsrc/comms/conserver Built with gcc 5.4 on netbsd-8, conser...

[hauke <hauke%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/f9109735b515
branches:  trunk
changeset: 368167:f9109735b515
user:      hauke <hauke%pkgsrc.org@localhost>
date:      Mon Sep 11 14:59:45 2017 +0000

description:
Built with gcc 5.4 on netbsd-8, conserver terminates because of a
buffer overflow in StrTime(), when it tries to stuff a 25 char string
into a 25 byte buffer.

diffstat:

 comms/conserver/Makefile                       |   8 ++++++--
 comms/conserver/distinfo                       |   3 ++-
 comms/conserver/patches/patch-conserver_util.c |  17 +++++++++++++++++
 3 files changed, 25 insertions(+), 3 deletions(-)

diffs (60 lines):

diff -r f970f582e177 -r f9109735b515 comms/conserver/Makefile
--- a/comms/conserver/Makefile  Mon Sep 11 14:53:02 2017 +0000
+++ b/comms/conserver/Makefile  Mon Sep 11 14:59:45 2017 +0000
@@ -1,8 +1,8 @@
-# $NetBSD: Makefile,v 1.27 2014/10/09 14:06:03 wiz Exp $
+# $NetBSD: Makefile,v 1.28 2017/09/11 15:00:03 hauke Exp $
 #
 
 DISTNAME=      conserver-7.2.7
-PKGREVISION=   3
+PKGREVISION=   4
 CATEGORIES=    comms
 MASTER_SITES=  http://www.conserver.com/
 
@@ -27,6 +27,10 @@
 CONFIGURE_ARGS+=       --with-64bit
 .endif
 
+# Debug
+CFLAGS+=               -g3
+INSTALL_UNSTRIPPED=    yes
+
 BUILD_DEFS+=   CONSERVER_DEFAULTPORT CONSERVER_DEFAULTHOST
 
 RCD_SCRIPTS=   conserver
diff -r f970f582e177 -r f9109735b515 comms/conserver/distinfo
--- a/comms/conserver/distinfo  Mon Sep 11 14:53:02 2017 +0000
+++ b/comms/conserver/distinfo  Mon Sep 11 14:59:45 2017 +0000
@@ -1,4 +1,4 @@
-$NetBSD: distinfo,v 1.8 2015/11/03 01:34:53 agc Exp $
+$NetBSD: distinfo,v 1.9 2017/09/11 15:00:03 hauke Exp $
 
 SHA1 (conserver-7.2.7.tar.gz) = e2dfe0d95ceab0e6c2db38161f540ec537d96132
 RMD160 (conserver-7.2.7.tar.gz) = 67fe555779293232933b30eea2efd5fcd86b6ea2
@@ -7,3 +7,4 @@
 SHA1 (patch-aa) = 01ab5e3430137e72b786164026785f91295232d4
 SHA1 (patch-ab) = 79125fed0be843528dd208664b90323cb23b9e8d
 SHA1 (patch-ac) = 45fb5253032347961f123ad9a75b72f7c2f15a2b
+SHA1 (patch-conserver_util.c) = 9bca7aeaa0239017aa5386218abcc0dd8dfd1b31
diff -r f970f582e177 -r f9109735b515 comms/conserver/patches/patch-conserver_util.c
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/comms/conserver/patches/patch-conserver_util.c    Mon Sep 11 14:59:45 2017 +0000
@@ -0,0 +1,17 @@
+$NetBSD: patch-conserver_util.c,v 1.1 2017/09/11 14:59:45 hauke Exp $
+
+Built with gcc 5.4 on netbsd-8, conserver terminates because of a
+buffer overflow in StrTime(), when it tries to stuff a 25 char string
+into a 25 byte buffer.
+
+--- conserver/util.c.orig      2003-04-06 12:29:48.000000000 +0000
++++ conserver/util.c
+@@ -77,7 +77,7 @@ StrTime(ltime)
+     time_t *ltime;
+ #endif
+ {
+-    static char curtime[25];
++    static char curtime[63];
+     time_t tyme;
+ 
+     tyme = time((time_t *) 0);