[pkgsrc/trunk]: pkgsrc/editors/vim-gtk3 vim-gtk3: Fix gtk3 build after gtk3 3...

[leot <leot%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/5068f2eafa32
branches:  trunk
changeset: 389969:5068f2eafa32
user:      leot <leot%pkgsrc.org@localhost>
date:      Mon Jan 14 20:20:22 2019 +0000

description:
vim-gtk3: Fix gtk3 build after gtk3 3.24.1 update

vim-gtk3 was affected by a problem similar to PR pkg/53688, and
the test failed to recognize gtk3 due `undefined reference to
`epoxy_has_glx'' when `checking for GTK - version >= 3.0.0' in the
configure phase because instead of linking to pkgsrc libepoxy it
linked against builtin libepoxy.  Despite that it successfully
built without gtk3 support but gvim failed at run time with
`E25: GUI cannot be used: Not enabled at compile time' error.

Sort x11 bl3 includes so instead of failing at run time it fails
at build time when linking vim.

Add a kludge to override `--x-libraries' and `--x-includes' passed
by x11.buildlink3.mk to avoid linking against builtin libepoxy and
fix gtk3 support.

Thanks to and discussed with <rhialto> and <morr>!

diffstat:

 editors/vim-gtk3/Makefile |  11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diffs (27 lines):

diff -r 58c5ef1559d4 -r 5068f2eafa32 editors/vim-gtk3/Makefile
--- a/editors/vim-gtk3/Makefile Mon Jan 14 17:22:18 2019 +0000
+++ b/editors/vim-gtk3/Makefile Mon Jan 14 20:20:22 2019 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.12 2018/11/14 22:21:24 kleink Exp $
+# $NetBSD: Makefile,v 1.13 2019/01/14 20:20:22 leot Exp $
 
 PKGNAME=       vim-gtk3-${VIM_VERSION}.${VIM_PATCHLEVEL}
 PKGREVISION=   2
@@ -40,9 +40,16 @@
 
 .include "../../converters/libiconv/buildlink3.mk"
 .include "../../devel/gettext-lib/buildlink3.mk"
+.include "../../x11/gtk3/buildlink3.mk"
 .include "../../x11/libXpm/buildlink3.mk"
 .include "../../x11/libXt/buildlink3.mk"
-.include "../../x11/gtk3/buildlink3.mk"
+
+# XXX: `--x-libraries' and `--x-includes' are injected to CONFIGURE_ARGS via
+# XXX: mk/x11.buildlink3.mk. Override them by redefining them to NONE in order
+# XXX: to avoid picked up possible undesidered libraries similarly to
+# XXX: PR pkg/53688.
+CONFIGURE_ARGS+=       --x-libraries=NONE
+CONFIGURE_ARGS+=       --x-includes=NONE
 
 .include "../../mk/termcap.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"