pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/lang/python27 lang/python27: Add comments about NIS de...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/677a2133acfe
branches:  trunk
changeset: 393874:677a2133acfe
user:      gdt <gdt%pkgsrc.org@localhost>
date:      Tue Mar 26 16:12:28 2019 +0000

description:
lang/python27: Add comments about NIS detection

The logic to determine inclusion of NIS PLIST entries is confusing.
Add comments to explain some and question some.

This is a comment-only change.

diffstat:

 lang/python27/Makefile |  9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diffs (33 lines):

diff -r 84a9dcc272fd -r 677a2133acfe lang/python27/Makefile
--- a/lang/python27/Makefile    Tue Mar 26 15:18:33 2019 +0000
+++ b/lang/python27/Makefile    Tue Mar 26 16:12:28 2019 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.77 2019/03/05 12:43:40 adam Exp $
+# $NetBSD: Makefile,v 1.78 2019/03/26 16:12:28 gdt Exp $
 
 .include "dist.mk"
 
@@ -104,6 +104,8 @@
 .endif
 
 .if ${OPSYS} == "IRIX"
+# Assume that IRIX (and IRIX alone) does not support a libpython.so.
+# Assume that 32-bit IRIX has NIS and 64-bit IRIX does not.
 .  if ${ABI} == "64"
 PLIST.no-nis=  yes
 .  else
@@ -111,9 +113,14 @@
 .  endif
 .else
 PLIST.dll=     yes
+# Determine if lib-dynload/nis.so (PLIST.nis) or
+# lib-dynload/nis-failed.so (PLIST.no-nis) will be built.
 .  if ${OPSYS} == "MirBSD" || "${OS_VARIANT}" == "chromeos"
 # neither nis nor no-nis
 .  elif ${OPSYS} != "NetBSD" || exists(/usr/bin/ypcat)
+# \todo Explain the "!= NetBSD"; that seems to declare that any
+# remaining system other than NetBSD will have NIS, even if ypcat is
+# missing.
 PLIST.nis=     yes
 .  else
 PLIST.no-nis=  yes



Home | Main Index | Thread Index | Old Index