pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/games pkgsrc doesn't support PREFIX with spaces or oth...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/d5e7ea23bf65
branches:  trunk
changeset: 374046:d5e7ea23bf65
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Sun Jan 14 15:26:46 2018 +0000

description:
pkgsrc doesn't support PREFIX with spaces or other special characters.
Therefore it is not necessary to add the :Q modifier to this variable
and several others.

pkglint -r -Wall --autofix --only :Q

diffstat:

 games/colchess-book-colchess/Makefile |   4 ++--
 games/colchess-book-large/Makefile    |   4 ++--
 games/colchess/Makefile               |   4 ++--
 games/crafty-book-medium/Makefile     |   4 ++--
 games/crafty-book-small/Makefile      |   4 ++--
 games/d2x/Makefile                    |   4 ++--
 games/exchess-book-medium/Makefile    |   4 ++--
 games/exchess-book-small/Makefile     |   4 ++--
 games/exchess/Makefile                |   4 ++--
 games/ggz-client-libs/Makefile        |   4 ++--
 games/gnome-games/Makefile            |   6 +++---
 games/icebreaker/Makefile             |   4 ++--
 games/knightcap-brain/Makefile        |  16 ++++++++--------
 games/koth/Makefile                   |   4 ++--
 games/lbreakout/Makefile              |   4 ++--
 games/lbreakout2/Makefile             |   4 ++--
 games/maelstrom-sdl/Makefile          |   4 ++--
 games/maelstrom-x11/Makefile          |   4 ++--
 games/monsterz/Makefile               |   4 ++--
 games/nethack-lib/Makefile.common     |   6 +++---
 games/netmaj/Makefile                 |   4 ++--
 games/powermanga/Makefile             |   6 +++---
 games/qstat/Makefile                  |   4 ++--
 games/quake/Makefile                  |   6 +++---
 games/quake6/Makefile                 |   4 ++--
 games/spaceracer/Makefile             |   4 ++--
 games/sudoku-cli/Makefile             |  14 +++++++-------
 games/svb/Makefile                    |   4 ++--
 games/tetrinetx/Makefile              |  22 +++++++++++-----------
 games/xbill/Makefile                  |   4 ++--
 games/xconq/Makefile                  |   8 ++++----
 games/xdoom/Makefile                  |   4 ++--
 games/xemeraldia/Makefile             |   6 +++---
 games/xgalaga/Makefile                |   4 ++--
 games/xjump/Makefile                  |   4 ++--
 games/xkobo/Makefile                  |   4 ++--
 games/xpat2/Makefile                  |   4 ++--
 37 files changed, 101 insertions(+), 101 deletions(-)

diffs (truncated from 739 to 300 lines):

diff -r fa2af77bbdec -r d5e7ea23bf65 games/colchess-book-colchess/Makefile
--- a/games/colchess-book-colchess/Makefile     Sun Jan 14 14:58:38 2018 +0000
+++ b/games/colchess-book-colchess/Makefile     Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.15 2017/08/01 17:40:11 wiz Exp $
+# $NetBSD: Makefile,v 1.16 2018/01/14 15:26:46 rillig Exp $
 
 DISTNAME=              colchess
 PKGNAME=               ${CHESS_ENGINE}-book-${DIST_SUBDIR}
@@ -21,7 +21,7 @@
 NO_BUILD=              yes
 
 PLIST_SUBST+=          CHESS_ENGINE=${CHESS_ENGINE:Q}
-PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE:Q}
+PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE}
 
 BOOKDIR=               ${PREFIX}/share/${CHESS_ENGINE}
 BOOK_FILE=             book.dat
diff -r fa2af77bbdec -r d5e7ea23bf65 games/colchess-book-large/Makefile
--- a/games/colchess-book-large/Makefile        Sun Jan 14 14:58:38 2018 +0000
+++ b/games/colchess-book-large/Makefile        Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.14 2012/10/06 11:54:33 asau Exp $
+# $NetBSD: Makefile,v 1.15 2018/01/14 15:26:46 rillig Exp $
 
 DISTNAME=              book_large
 PKGNAME=               ${CHESS_ENGINE}-book-large-20000512
@@ -19,7 +19,7 @@
 NO_CONFIGURE=          yes
 
 PLIST_SUBST+=          CHESS_ENGINE=${CHESS_ENGINE:Q}
-PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE:Q}
+PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE}
 
 BOOKDIR=               ${PREFIX}/share/${CHESS_ENGINE}
 BOOK_FILE=             book.dat
diff -r fa2af77bbdec -r d5e7ea23bf65 games/colchess/Makefile
--- a/games/colchess/Makefile   Sun Jan 14 14:58:38 2018 +0000
+++ b/games/colchess/Makefile   Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.17 2017/08/01 17:40:11 wiz Exp $
+# $NetBSD: Makefile,v 1.18 2018/01/14 15:26:46 rillig Exp $
 
 DISTNAME=              colchess
 PKGNAME=               ${DISTNAME}-7.0
@@ -11,7 +11,7 @@
 COMMENT=               Chess analysis engine
 
 DIST_SUBDIR=           ${PKGNAME_NOREV}
-MAKE_ENV+=             PREFIX=${PREFIX:Q}
+MAKE_ENV+=             PREFIX=${PREFIX}
 NO_CONFIGURE=          yes
 WRKSRC=                        ${WRKDIR}/ColChess
 
diff -r fa2af77bbdec -r d5e7ea23bf65 games/crafty-book-medium/Makefile
--- a/games/crafty-book-medium/Makefile Sun Jan 14 14:58:38 2018 +0000
+++ b/games/crafty-book-medium/Makefile Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.16 2012/10/06 11:54:34 asau Exp $
+# $NetBSD: Makefile,v 1.17 2018/01/14 15:26:46 rillig Exp $
 
 DISTNAME=              medium
 PKGNAME=               ${CHESS_ENGINE}-book-${DISTNAME}-20000511
@@ -20,7 +20,7 @@
 NO_CONFIGURE=          yes
 
 PLIST_SUBST+=          CHESS_ENGINE=${CHESS_ENGINE:Q}
-PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE:Q}
+PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE}
 
 BOOKDIR=               ${PREFIX}/lib/${CHESS_ENGINE}
 PGN_FILE=              book.txt
diff -r fa2af77bbdec -r d5e7ea23bf65 games/crafty-book-small/Makefile
--- a/games/crafty-book-small/Makefile  Sun Jan 14 14:58:38 2018 +0000
+++ b/games/crafty-book-small/Makefile  Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.16 2012/10/06 11:54:34 asau Exp $
+# $NetBSD: Makefile,v 1.17 2018/01/14 15:26:46 rillig Exp $
 
 DISTNAME=              small
 PKGNAME=               ${CHESS_ENGINE}-book-${DISTNAME}-20000511
@@ -20,7 +20,7 @@
 NO_CONFIGURE=          yes
 
 PLIST_SUBST+=          CHESS_ENGINE=${CHESS_ENGINE:Q}
-PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE:Q}
+PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE}
 
 BOOKDIR=               ${PREFIX}/lib/${CHESS_ENGINE}
 PGN_FILE=              ${DISTNAME}.txt
diff -r fa2af77bbdec -r d5e7ea23bf65 games/d2x/Makefile
--- a/games/d2x/Makefile        Sun Jan 14 14:58:38 2018 +0000
+++ b/games/d2x/Makefile        Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.22 2015/04/25 14:22:53 tnn Exp $
+# $NetBSD: Makefile,v 1.23 2018/01/14 15:26:46 rillig Exp $
 #
 
 DISTNAME=      d2x-0.2.5
@@ -22,7 +22,7 @@
 # support
 #
 CONFIGURE_ARGS+=       --disable-network
-CONFIGURE_ARGS+=       --prefix=${PREFIX:Q}
+CONFIGURE_ARGS+=       --prefix=${PREFIX}
 CONFIGURE_ARGS+=       --with-sharepath=${D2X_DATA:Q}
 
 .include "../../devel/SDL/buildlink3.mk"
diff -r fa2af77bbdec -r d5e7ea23bf65 games/exchess-book-medium/Makefile
--- a/games/exchess-book-medium/Makefile        Sun Jan 14 14:58:38 2018 +0000
+++ b/games/exchess-book-medium/Makefile        Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.18 2014/09/11 17:08:00 jperkin Exp $
+# $NetBSD: Makefile,v 1.19 2018/01/14 15:26:46 rillig Exp $
 
 DISTNAME=              medium
 PKGNAME=               ${CHESS_ENGINE}-book-${DISTNAME}-20140911
@@ -20,7 +20,7 @@
 NO_CONFIGURE=          yes
 
 PLIST_SUBST+=          CHESS_ENGINE=${CHESS_ENGINE:Q}
-PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE:Q}
+PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE}
 
 BOOKDIR=               ${PREFIX}/lib/${CHESS_ENGINE}
 PGN_FILE=              book.txt
diff -r fa2af77bbdec -r d5e7ea23bf65 games/exchess-book-small/Makefile
--- a/games/exchess-book-small/Makefile Sun Jan 14 14:58:38 2018 +0000
+++ b/games/exchess-book-small/Makefile Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.18 2014/09/11 17:08:00 jperkin Exp $
+# $NetBSD: Makefile,v 1.19 2018/01/14 15:26:47 rillig Exp $
 
 DISTNAME=              small
 PKGNAME=               ${CHESS_ENGINE}-book-${DISTNAME}-20140911
@@ -20,7 +20,7 @@
 NO_CONFIGURE=          yes
 
 PLIST_SUBST+=          CHESS_ENGINE=${CHESS_ENGINE:Q}
-PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE:Q}
+PLIST_SUBST+=          BOOK_FILE=${BOOK_FILE}
 
 BOOKDIR=               ${PREFIX}/lib/${CHESS_ENGINE}
 PGN_FILE=              ${DISTNAME}.txt
diff -r fa2af77bbdec -r d5e7ea23bf65 games/exchess/Makefile
--- a/games/exchess/Makefile    Sun Jan 14 14:58:38 2018 +0000
+++ b/games/exchess/Makefile    Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.17 2014/09/11 16:59:16 jperkin Exp $
+# $NetBSD: Makefile,v 1.18 2018/01/14 15:26:46 rillig Exp $
 
 DISTNAME=              EXchess_v7.31beta
 PKGNAME=               exchess-7.31beta
@@ -18,7 +18,7 @@
 LIBDIR=                        ${PREFIX}/lib/exchess
 DOCDIR=                        ${PREFIX}/share/doc/exchess
 
-CFLAGS+=               -DEXCHESS_DIR=${LIBDIR:Q}
+CFLAGS+=               -DEXCHESS_DIR=${LIBDIR}
 LDFLAGS+=              ${PTHREAD_LDFLAGS}
 LIBS+=                 ${PTHREAD_LIBS}
 
diff -r fa2af77bbdec -r d5e7ea23bf65 games/ggz-client-libs/Makefile
--- a/games/ggz-client-libs/Makefile    Sun Jan 14 14:58:38 2018 +0000
+++ b/games/ggz-client-libs/Makefile    Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.13 2016/09/19 13:04:18 wiz Exp $
+# $NetBSD: Makefile,v 1.14 2018/01/14 15:26:47 rillig Exp $
 #
 
 DISTNAME=      ggz-client-libs-0.0.14.1
@@ -15,7 +15,7 @@
 USE_TOOLS+=    msgfmt
 
 CONFIGURE_ARGS+=       --enable-debug-gdb
-CONFIGURE_ARGS+=       --sysconfdir=${PKG_SYSCONFDIR:Q}
+CONFIGURE_ARGS+=       --sysconfdir=${PKG_SYSCONFDIR}
 
 MAKE_DIRS+=    ${PKG_SYSCONFDIR}/xdg/menus ${PKG_SYSCONFDIR}/xdg/menus/applications-merged
 CONF_FILES+=   ${PREFIX}/share/examples/ggz-client-libs/ggz.menu \
diff -r fa2af77bbdec -r d5e7ea23bf65 games/gnome-games/Makefile
--- a/games/gnome-games/Makefile        Sun Jan 14 14:58:38 2018 +0000
+++ b/games/gnome-games/Makefile        Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.157 2017/11/23 17:19:54 wiz Exp $
+# $NetBSD: Makefile,v 1.158 2018/01/14 15:26:47 rillig Exp $
 
 DISTNAME=              gnome-games-2.32.1
 PKGREVISION=           34
@@ -23,9 +23,9 @@
 USE_LIBTOOL=           yes
 
 GNU_CONFIGURE=         yes
-CONFIGURE_ENV+=                PKGLOCALEDIR=${PKGLOCALEDIR:Q}
+CONFIGURE_ENV+=                PKGLOCALEDIR=${PKGLOCALEDIR}
 CONFIGURE_ENV+=                ac_cv_path_MSGFMT=msgfmt
-CONFIGURE_ARGS+=       --localstatedir=${VARBASE:Q}
+CONFIGURE_ARGS+=       --localstatedir=${VARBASE}
 CONFIGURE_ARGS+=       --enable-omitgames=lightsoff
 
 FILES_SUBST+=          INSTALL=${INSTALL:Q}
diff -r fa2af77bbdec -r d5e7ea23bf65 games/icebreaker/Makefile
--- a/games/icebreaker/Makefile Sun Jan 14 14:58:38 2018 +0000
+++ b/games/icebreaker/Makefile Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.32 2017/08/16 20:21:09 wiz Exp $
+# $NetBSD: Makefile,v 1.33 2018/01/14 15:26:47 rillig Exp $
 #
 
 DISTNAME=      icebreaker-1.9.7
@@ -13,7 +13,7 @@
 
 USE_TOOLS+=    gmake
 MAKE_ENV+=     mandir="${PREFIX}/man" highscoredir="/var/games"
-MAKE_ENV+=     prefix=${PREFIX:Q}
+MAKE_ENV+=     prefix=${PREFIX}
 
 SETGIDGAME=    yes
 SPECIAL_PERMS= bin/icebreaker ${SETGID_GAMES_PERMS}
diff -r fa2af77bbdec -r d5e7ea23bf65 games/knightcap-brain/Makefile
--- a/games/knightcap-brain/Makefile    Sun Jan 14 14:58:38 2018 +0000
+++ b/games/knightcap-brain/Makefile    Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.18 2015/01/04 06:11:03 dholland Exp $
+# $NetBSD: Makefile,v 1.19 2018/01/14 15:26:47 rillig Exp $
 
 DISTNAME=              new_brain
 PKGNAME=               knightcap-brain-19980616
@@ -42,14 +42,14 @@
 INSTALLATION_DIRS=     bin
 
 do-build:
-       ${SED} -e "s,@PREFIX@,${PREFIX},g" < ${FILESDIR:Q}/newbrain.sh \
-               > ${WRKSRC:Q}/newbrain.sh
+       ${SED} -e "s,@PREFIX@,${PREFIX},g" < ${FILESDIR}/newbrain.sh \
+               > ${WRKSRC}/newbrain.sh
 
 do-install:
-       ${INSTALL_SCRIPT} ${WRKSRC:Q}/newbrain.sh \
-               ${DESTDIR}${PREFIX:Q}/bin/newbrain
-       ${INSTALL_DATA_DIR} ${DESTDIR}${EGDIR:Q}
-       ${INSTALL_DATA} ${DISTDIR:Q}/${DIST_SUBDIR:Q}/new_brain.dat \
-               ${DESTDIR}${EGDIR:Q}/brain.dat
+       ${INSTALL_SCRIPT} ${WRKSRC}/newbrain.sh \
+               ${DESTDIR}${PREFIX}/bin/newbrain
+       ${INSTALL_DATA_DIR} ${DESTDIR}${EGDIR}
+       ${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/new_brain.dat \
+               ${DESTDIR}${EGDIR}/brain.dat
 
 .include "../../mk/bsd.pkg.mk"
diff -r fa2af77bbdec -r d5e7ea23bf65 games/koth/Makefile
--- a/games/koth/Makefile       Sun Jan 14 14:58:38 2018 +0000
+++ b/games/koth/Makefile       Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.26 2015/08/17 17:11:23 wiz Exp $
+# $NetBSD: Makefile,v 1.27 2018/01/14 15:26:47 rillig Exp $
 #
 
 DISTNAME=      koth-0.8.0
@@ -13,7 +13,7 @@
 
 PTHREAD_AUTO_VARS=     yes
 GNU_CONFIGURE= YES
-CPPFLAGS+=     -DPKG_SYSCONFDIR="\"${PKG_SYSCONFDIR:Q}\""
+CPPFLAGS+=     -DPKG_SYSCONFDIR="\"${PKG_SYSCONFDIR}\""
 
 EGDIR=         ${PREFIX}/share/examples/koth
 CONF_FILES=    ${EGDIR}/koth.cfg ${PKG_SYSCONFDIR}/koth.cfg
diff -r fa2af77bbdec -r d5e7ea23bf65 games/lbreakout/Makefile
--- a/games/lbreakout/Makefile  Sun Jan 14 14:58:38 2018 +0000
+++ b/games/lbreakout/Makefile  Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.35 2015/04/25 14:23:00 tnn Exp $
+# $NetBSD: Makefile,v 1.36 2018/01/14 15:26:47 rillig Exp $
 
 DISTNAME=      lbreakout-010315
 PKGREVISION=   12
@@ -10,7 +10,7 @@
 COMMENT=       Breakout-style arcade game
 
 GNU_CONFIGURE=         YES
-CONFIGURE_ENV+=                VARBASE=${VARBASE:Q}
+CONFIGURE_ENV+=                VARBASE=${VARBASE}
 CONFIGURE_ARGS+=       --disable-sound
 
 USE_LANGUAGES= c c++
diff -r fa2af77bbdec -r d5e7ea23bf65 games/lbreakout2/Makefile
--- a/games/lbreakout2/Makefile Sun Jan 14 14:58:38 2018 +0000
+++ b/games/lbreakout2/Makefile Sun Jan 14 15:26:46 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.40 2015/04/25 14:23:00 tnn Exp $
+# $NetBSD: Makefile,v 1.41 2018/01/14 15:26:47 rillig Exp $
 
 DISTNAME=      lbreakout2-2.6.4
 PKGREVISION=   2
@@ -11,7 +11,7 @@
 LICENSE=       gnu-gpl-v2
 
 GNU_CONFIGURE=         yes
-CONFIGURE_ARGS+=       --localstatedir=${VARBASE:Q}/games



Home | Main Index | Thread Index | Old Index