[pkgsrc/trunk]: pkgsrc/x11/py-kde4 PyList_SET_ITEM doesn't return an interest...

[joerg <joerg%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/19b0f262ccf6
branches:  trunk
changeset: 355942:19b0f262ccf6
user:      joerg <joerg%pkgsrc.org@localhost>
date:      Fri Dec 16 00:04:54 2016 +0000

description:
PyList_SET_ITEM doesn't return an interesting value, so avoid pointer
ordering issues.

diffstat:

 x11/py-kde4/Makefile                                    |   4 +-
 x11/py-kde4/distinfo                                    |   4 ++-
 x11/py-kde4/patches/patch-sip_solid_powermanagement.sip |  22 +++++++++++++++++
 x11/py-kde4/patches/patch-sip_solid_predicate.sip       |  22 +++++++++++++++++
 4 files changed, 49 insertions(+), 3 deletions(-)

diffs (80 lines):

diff -r 5c52c46038fd -r 19b0f262ccf6 x11/py-kde4/Makefile
--- a/x11/py-kde4/Makefile      Fri Dec 16 00:04:03 2016 +0000
+++ b/x11/py-kde4/Makefile      Fri Dec 16 00:04:54 2016 +0000
@@ -1,7 +1,7 @@
-# $NetBSD: Makefile,v 1.51 2016/10/07 18:26:13 adam Exp $
+# $NetBSD: Makefile,v 1.52 2016/12/16 00:04:54 joerg Exp $
 
 PKGNAME=       ${PYPKGPREFIX}-kde4-${_KDE_VERSION}
-PKGREVISION=   4
+PKGREVISION=   5
 DISTNAME=      pykde4-${_KDE_VERSION}
 CATEGORIES=    misc
 COMMENT=       Python bindings for the KDE integrated X11 desktop
diff -r 5c52c46038fd -r 19b0f262ccf6 x11/py-kde4/distinfo
--- a/x11/py-kde4/distinfo      Fri Dec 16 00:04:03 2016 +0000
+++ b/x11/py-kde4/distinfo      Fri Dec 16 00:04:54 2016 +0000
@@ -1,4 +1,4 @@
-$NetBSD: distinfo,v 1.12 2016/01/10 19:07:58 markd Exp $
+$NetBSD: distinfo,v 1.13 2016/12/16 00:04:54 joerg Exp $
 
 SHA1 (pykde4-4.14.3.tar.xz) = 9cc8e70d3b107a876cf579beab1f582861cd2c48
 RMD160 (pykde4-4.14.3.tar.xz) = 3ea2492cd31704e559456cb78dd85660fae7e74c
@@ -6,3 +6,5 @@
 Size (pykde4-4.14.3.tar.xz) = 2006504 bytes
 SHA1 (patch-CMakeLists.txt) = f09b05a952c3ad4e08cfde47a24ffb17e22edd6c
 SHA1 (patch-__init__.py) = 721287a0ec82b79ea4a502526ed98ba44c6d979f
+SHA1 (patch-sip_solid_powermanagement.sip) = a0b961cca434b1998bcd86bf781af72b92cbf0ca
+SHA1 (patch-sip_solid_predicate.sip) = 0304cbd05eb6f1b878db2a2411e218158ba366fa
diff -r 5c52c46038fd -r 19b0f262ccf6 x11/py-kde4/patches/patch-sip_solid_powermanagement.sip
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/x11/py-kde4/patches/patch-sip_solid_powermanagement.sip   Fri Dec 16 00:04:54 2016 +0000
@@ -0,0 +1,22 @@
+$NetBSD: patch-sip_solid_powermanagement.sip,v 1.1 2016/12/16 00:04:54 joerg Exp $
+
+--- sip/solid/powermanagement.sip.orig 2016-12-15 12:53:38.625458181 +0000
++++ sip/solid/powermanagement.sip
+@@ -83,7 +83,7 @@ bool                    stopSuppressingS
+ #else
+         PyObject *obj = PyInt_FromLong ((long) value);
+ #endif
+-        if (obj == NULL || PyList_SET_ITEM (l, i, obj) < 0)
++        if (obj == NULL)
+         {
+             Py_DECREF(l);
+ 
+@@ -92,7 +92,7 @@ bool                    stopSuppressingS
+ 
+             return NULL;
+         }
+-
++        PyList_SET_ITEM (l, i, obj);
+         Py_DECREF(obj);
+         i++;
+     }
diff -r 5c52c46038fd -r 19b0f262ccf6 x11/py-kde4/patches/patch-sip_solid_predicate.sip
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/x11/py-kde4/patches/patch-sip_solid_predicate.sip Fri Dec 16 00:04:54 2016 +0000
@@ -0,0 +1,22 @@
+$NetBSD: patch-sip_solid_predicate.sip,v 1.1 2016/12/16 00:04:54 joerg Exp $
+
+--- sip/solid/predicate.sip.orig       2016-12-15 12:52:41.763919370 +0000
++++ sip/solid/predicate.sip
+@@ -112,7 +112,7 @@ Py_BEGIN_ALLOW_THREADS
+ #else
+         PyObject *obj = PyInt_FromLong ((long) value);
+ #endif
+-        if (obj == NULL || PyList_SET_ITEM (l, i, obj) < 0)
++        if (obj == NULL)
+         {
+             Py_DECREF(l);
+ 
+@@ -121,7 +121,7 @@ Py_BEGIN_ALLOW_THREADS
+ 
+             return NULL;
+         }
+-
++        PyList_SET_ITEM (l, i, obj);
+         Py_DECREF(obj);
+         i++;
+     }