[pkgsrc/trunk]: pkgsrc/databases ${PGUSER} doesn't have read permission in ev...

[schmonz <schmonz%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/713f3e48c08c
branches:  trunk
changeset: 391422:713f3e48c08c
user:      schmonz <schmonz%pkgsrc.org@localhost>
date:      Wed Feb 06 18:45:55 2019 +0000

description:
${PGUSER} doesn't have read permission in every conceivable working
directory, which causes errors for several actions. But the caller's
working directory isn't needed for anything. cd into ${pgsql_home}
early, just after reading rc.conf. Bump PKGREVISION.

diffstat:

 databases/postgresql10-server/Makefile       |  3 ++-
 databases/postgresql10-server/files/pgsql.sh |  4 +++-
 databases/postgresql11-server/Makefile       |  3 ++-
 databases/postgresql11-server/files/pgsql.sh |  4 +++-
 databases/postgresql93-server/Makefile       |  3 ++-
 databases/postgresql93-server/files/pgsql.sh |  4 +++-
 databases/postgresql94-server/Makefile       |  3 ++-
 databases/postgresql94-server/files/pgsql.sh |  4 +++-
 databases/postgresql95-server/Makefile       |  3 ++-
 databases/postgresql95-server/files/pgsql.sh |  4 +++-
 databases/postgresql96-server/Makefile       |  3 ++-
 databases/postgresql96-server/files/pgsql.sh |  4 +++-
 12 files changed, 30 insertions(+), 12 deletions(-)

diffs (192 lines):

diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql10-server/Makefile
--- a/databases/postgresql10-server/Makefile    Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql10-server/Makefile    Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.4 2018/11/09 18:12:24 adam Exp $
+# $NetBSD: Makefile,v 1.5 2019/02/06 18:45:55 schmonz Exp $
 
 PKGNAME=       ${DISTNAME:C/-/10-server-/}
+PKGREVISION=   1
 COMMENT=       PostgreSQL database server programs
 
 # mips has no TAS implementation
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql10-server/files/pgsql.sh
--- a/databases/postgresql10-server/files/pgsql.sh      Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql10-server/files/pgsql.sh      Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: pgsql.sh,v 1.1 2017/10/23 20:33:50 adam Exp $
+# $NetBSD: pgsql.sh,v 1.2 2019/02/06 18:45:55 schmonz Exp $
 #
 # PostgreSQL database rc.d control script
 #
@@ -45,6 +45,8 @@
        . /etc/rc.conf
 fi
 
+cd "${pgsql_home}"
+
 command_args="-w -s -D ${pgsql_home}/data -m fast -l ${pgsql_home}/errlog"
 if [ -n "${pgsql_flags}" ]; then
        command_args="${command_args} -o \\\"${pgsql_flags}\\\""
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql11-server/Makefile
--- a/databases/postgresql11-server/Makefile    Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql11-server/Makefile    Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.1 2018/10/23 16:02:52 adam Exp $
+# $NetBSD: Makefile,v 1.2 2019/02/06 18:45:55 schmonz Exp $
 
 PKGNAME=       ${DISTNAME:C/-/11-server-/}
+PKGREVISION=   1
 COMMENT=       PostgreSQL database server programs
 
 # mips has no TAS implementation
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql11-server/files/pgsql.sh
--- a/databases/postgresql11-server/files/pgsql.sh      Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql11-server/files/pgsql.sh      Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: pgsql.sh,v 1.1 2018/10/23 16:02:52 adam Exp $
+# $NetBSD: pgsql.sh,v 1.2 2019/02/06 18:45:55 schmonz Exp $
 #
 # PostgreSQL database rc.d control script
 #
@@ -45,6 +45,8 @@
        . /etc/rc.conf
 fi
 
+cd "${pgsql_home}"
+
 command_args="-w -s -D ${pgsql_home}/data -m fast -l ${pgsql_home}/errlog"
 if [ -n "${pgsql_flags}" ]; then
        command_args="${command_args} -o \\\"${pgsql_flags}\\\""
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql93-server/Makefile
--- a/databases/postgresql93-server/Makefile    Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql93-server/Makefile    Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.14 2018/11/09 18:12:25 adam Exp $
+# $NetBSD: Makefile,v 1.15 2019/02/06 18:45:55 schmonz Exp $
 
 PKGNAME=       ${DISTNAME:C/-/93-server-/}
+PKGREVISION=   1
 COMMENT=       PostgreSQL database server programs
 
 # mips has no TAS implementation
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql93-server/files/pgsql.sh
--- a/databases/postgresql93-server/files/pgsql.sh      Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql93-server/files/pgsql.sh      Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: pgsql.sh,v 1.1 2013/09/10 15:32:33 adam Exp $
+# $NetBSD: pgsql.sh,v 1.2 2019/02/06 18:45:55 schmonz Exp $
 #
 # PostgreSQL database rc.d control script
 #
@@ -45,6 +45,8 @@
        . /etc/rc.conf
 fi
 
+cd "${pgsql_home}"
+
 command_args="-w -s -D ${pgsql_home}/data -m fast -l ${pgsql_home}/errlog"
 if [ -n "${pgsql_flags}" ]; then
        command_args="${command_args} -o \\\"${pgsql_flags}\\\""
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql94-server/Makefile
--- a/databases/postgresql94-server/Makefile    Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql94-server/Makefile    Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.6 2018/11/09 18:12:26 adam Exp $
+# $NetBSD: Makefile,v 1.7 2019/02/06 18:45:55 schmonz Exp $
 
 PKGNAME=       ${DISTNAME:C/-/94-server-/}
+PKGREVISION=   1
 COMMENT=       PostgreSQL database server programs
 
 # mips has no TAS implementation
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql94-server/files/pgsql.sh
--- a/databases/postgresql94-server/files/pgsql.sh      Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql94-server/files/pgsql.sh      Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: pgsql.sh,v 1.1 2015/01/14 21:01:19 adam Exp $
+# $NetBSD: pgsql.sh,v 1.2 2019/02/06 18:45:55 schmonz Exp $
 #
 # PostgreSQL database rc.d control script
 #
@@ -45,6 +45,8 @@
        . /etc/rc.conf
 fi
 
+cd "${pgsql_home}"
+
 command_args="-w -s -D ${pgsql_home}/data -m fast -l ${pgsql_home}/errlog"
 if [ -n "${pgsql_flags}" ]; then
        command_args="${command_args} -o \\\"${pgsql_flags}\\\""
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql95-server/Makefile
--- a/databases/postgresql95-server/Makefile    Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql95-server/Makefile    Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.6 2018/11/09 18:12:27 adam Exp $
+# $NetBSD: Makefile,v 1.7 2019/02/06 18:45:55 schmonz Exp $
 
 PKGNAME=       ${DISTNAME:C/-/95-server-/}
+PKGREVISION=   1
 COMMENT=       PostgreSQL database server programs
 
 # mips has no TAS implementation
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql95-server/files/pgsql.sh
--- a/databases/postgresql95-server/files/pgsql.sh      Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql95-server/files/pgsql.sh      Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: pgsql.sh,v 1.1 2016/02/25 21:37:37 tnn Exp $
+# $NetBSD: pgsql.sh,v 1.2 2019/02/06 18:45:55 schmonz Exp $
 #
 # PostgreSQL database rc.d control script
 #
@@ -45,6 +45,8 @@
        . /etc/rc.conf
 fi
 
+cd "${pgsql_home}"
+
 command_args="-w -s -D ${pgsql_home}/data -m fast -l ${pgsql_home}/errlog"
 if [ -n "${pgsql_flags}" ]; then
        command_args="${command_args} -o \\\"${pgsql_flags}\\\""
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql96-server/Makefile
--- a/databases/postgresql96-server/Makefile    Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql96-server/Makefile    Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.3 2018/11/09 18:12:28 adam Exp $
+# $NetBSD: Makefile,v 1.4 2019/02/06 18:45:56 schmonz Exp $
 
 PKGNAME=       ${DISTNAME:C/-/96-server-/}
+PKGREVISION=   1
 COMMENT=       PostgreSQL database server programs
 
 # mips has no TAS implementation
diff -r e457d78386f6 -r 713f3e48c08c databases/postgresql96-server/files/pgsql.sh
--- a/databases/postgresql96-server/files/pgsql.sh      Wed Feb 06 17:51:01 2019 +0000
+++ b/databases/postgresql96-server/files/pgsql.sh      Wed Feb 06 18:45:55 2019 +0000
@@ -1,6 +1,6 @@
 #!@RCD_SCRIPTS_SHELL@
 #
-# $NetBSD: pgsql.sh,v 1.1 2016/10/29 19:41:55 adam Exp $
+# $NetBSD: pgsql.sh,v 1.2 2019/02/06 18:45:56 schmonz Exp $
 #
 # PostgreSQL database rc.d control script
 #
@@ -45,6 +45,8 @@
        . /etc/rc.conf
 fi
 
+cd "${pgsql_home}"
+
 command_args="-w -s -D ${pgsql_home}/data -m fast -l ${pgsql_home}/errlog"
 if [ -n "${pgsql_flags}" ]; then
        command_args="${command_args} -o \\\"${pgsql_flags}\\\""