pkgsrc-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[pkgsrc/trunk]: pkgsrc/lang openjdk[78]: Add a \todo comment about the cups d...
details: https://anonhg.NetBSD.org/pkgsrc/rev/87361eb63846
branches: trunk
changeset: 382598:87361eb63846
user: gdt <gdt%pkgsrc.org@localhost>
date: Sat Jul 07 11:48:18 2018 +0000
description:
openjdk[78]: Add a \todo comment about the cups dependency.
Having a language install a printing system violates the Principle of
Least Astonishment. Add a comment to be replaced with an explanation
of why this is necessary or helpful.
diffstat:
lang/openjdk7/Makefile | 5 ++++-
lang/openjdk8/Makefile | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diffs (38 lines):
diff -r 1345d50846c1 -r 87361eb63846 lang/openjdk7/Makefile
--- a/lang/openjdk7/Makefile Sat Jul 07 11:43:01 2018 +0000
+++ b/lang/openjdk7/Makefile Sat Jul 07 11:48:18 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.124 2018/04/17 22:29:40 wiz Exp $
+# $NetBSD: Makefile,v 1.125 2018/07/07 11:48:18 gdt Exp $
JDK_MICRO= 141
DISTNAME= openjdk-1.7.${JDK_MICRO}-20170813
@@ -295,6 +295,9 @@
.include "../../devel/zlib/buildlink3.mk"
.include "../../fonts/fontconfig/buildlink3.mk"
.include "../../graphics/freetype2/buildlink3.mk"
+# \todo Explain why cups needs to be included, because having the
+# package installed is unexpected for those who have not chosen to use
+# cups.
BUILDLINK_DEPMETHOD.cups-base?= build
.include "../../print/cups-base/buildlink3.mk"
.include "../../mk/java-env.mk"
diff -r 1345d50846c1 -r 87361eb63846 lang/openjdk8/Makefile
--- a/lang/openjdk8/Makefile Sat Jul 07 11:43:01 2018 +0000
+++ b/lang/openjdk8/Makefile Sat Jul 07 11:48:18 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.65 2018/05/26 21:26:46 ryoon Exp $
+# $NetBSD: Makefile,v 1.66 2018/07/07 11:48:18 gdt Exp $
DISTNAME= openjdk-1.8.172-20180527
PKGNAME= openjdk8-1.8.172
@@ -270,6 +270,9 @@
.include "../../devel/zlib/buildlink3.mk"
.include "../../fonts/fontconfig/buildlink3.mk"
.include "../../graphics/freetype2/buildlink3.mk"
+# \todo Explain why cups needs to be included, because having the
+# package installed is unexpected for those who have not chosen to use
+# cups.
BUILDLINK_DEPMETHOD.cups-base?= build
.include "../../print/cups-base/buildlink3.mk"
.include "../../mk/java-env.mk"
Home |
Main Index |
Thread Index |
Old Index