pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/61002: net/tor: SMF manifest has no refresh method, so svcadm refresh doesn't reload torrc



The following reply was made to PR pkg/61002; it has been noted by GNATS.

From: Ali Raheem <aliraheem%proton.me@localhost>
To: "gnats-bugs%NetBSD.org@localhost" <gnats-bugs%NetBSD.org@localhost>
Cc: 
Subject: Re: pkg/61002: net/tor: SMF manifest has no refresh method, so svcadm refresh doesn't reload torrc
Date: Sat, 14 Nov 2026 09:51:50 +0000

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --------02379783de138e7b41af42ecb92375a3ad5e980401409a9ca43c128d7c5059f1
 Content-Type: multipart/mixed;boundary=---------------------25dee1d8fed5b634c5fb3fd691d438f9
 
 -----------------------25dee1d8fed5b634c5fb3fd691d438f9
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;charset=utf-8
 
 My suggested patch for pkg/61002
 
 This patch adds a refresh method to files/smf/manifest.xml that sends SIGH=
 UP to trigger a reload of the configuration, and adds PKGREVISION =3D 1 to=
  the Makefile.
 
 I have tested this with the tor-0.4.9.16 binary package on OmniOS r151060,=
  by adding the refresh method to the installed manifest.
 
 - Confirmed svcadm refresh pkgsrc/tor triggers tor to report "Received rel=
 oad signal (hup)..." and configuration is updated.
 - Confirmed restart/disable behave as before.
 
 I haven't built the tor package with the patch applied.
 
 Kind regards,
 
 Ali
 
 
 
 
 diff -ru a/net/tor/Makefile b/net/tor/Makefile
 --- a/net/tor/Makefile	Sat Nov 14 09:01:00 2026
 +++ b/net/tor/Makefile	Sat Nov 14 09:07:46 2026
 @@ -1,6 +1,7 @@
  # $NetBSD: Makefile,v 1.205 2026/11/09 08:32:35 adam Exp $
  =
 
 
  DISTNAME=3D	tor-0.4.9.16
 +PKGREVISION=3D	1
  CATEGORIES=3D	net security
  MASTER_SITES=3D	https://dist.torproject.org/
  =
 
 
 diff -ru a/net/tor/files/smf/manifest.xml b/net/tor/files/smf/manifest.xml
 --- a/net/tor/files/smf/manifest.xml	Sat Nov 14 09:01:10 2026
 +++ b/net/tor/files/smf/manifest.xml	Sat Nov 14 09:04:51 2026
 @@ -14,6 +14,7 @@
        <method_credential user=3D"@TOR_USER@" group=3D"@TOR_GROUP@"/>
      </method_context>
      <exec_method type=3D"method" name=3D"start" exec=3D"@PREFIX@/bin/tor =
 --RunAsDaemon 1 --DataDirectory @PKG_HOME@" timeout_seconds=3D"60"/>
 +    <exec_method type=3D"method" name=3D"refresh" exec=3D":kill -HUP" tim=
 eout_seconds=3D"60"/>
      <exec_method type=3D"method" name=3D"stop" exec=3D":kill" timeout_sec=
 onds=3D"60"/>
      <property_group name=3D"startd" type=3D"framework">
        <propval name=3D"duration" type=3D"astring" value=3D"contract"/>
 
 -----------------------25dee1d8fed5b634c5fb3fd691d438f9
 Content-Type: application/octet-stream; filename="tor-smf-refresh.diff"; name="tor-smf-refresh.diff"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="tor-smf-refresh.diff"; name="tor-smf-refresh.diff"
 
 ZGlmZiAtcnUgYS9uZXQvdG9yL01ha2VmaWxlIGIvbmV0L3Rvci9NYWtlZmlsZQotLS0gYS9uZXQv
 dG9yL01ha2VmaWxlCVNhdCBOb3YgMTQgMDk6MDE6MDAgMjAyNgorKysgYi9uZXQvdG9yL01ha2Vm
 aWxlCVNhdCBOb3YgMTQgMDk6MDc6NDYgMjAyNgpAQCAtMSw2ICsxLDcgQEAKICMgJE5ldEJTRDog
 TWFrZWZpbGUsdiAxLjIwNSAyMDI2LzExLzA5IDA4OjMyOjM1IGFkYW0gRXhwICQKIAogRElTVE5B
 TUU9CXRvci0wLjQuOS4xNgorUEtHUkVWSVNJT049CTEKIENBVEVHT1JJRVM9CW5ldCBzZWN1cml0
 eQogTUFTVEVSX1NJVEVTPQlodHRwczovL2Rpc3QudG9ycHJvamVjdC5vcmcvCiAKZGlmZiAtcnUg
 YS9uZXQvdG9yL2ZpbGVzL3NtZi9tYW5pZmVzdC54bWwgYi9uZXQvdG9yL2ZpbGVzL3NtZi9tYW5p
 ZmVzdC54bWwKLS0tIGEvbmV0L3Rvci9maWxlcy9zbWYvbWFuaWZlc3QueG1sCVNhdCBOb3YgMTQg
 MDk6MDE6MTAgMjAyNgorKysgYi9uZXQvdG9yL2ZpbGVzL3NtZi9tYW5pZmVzdC54bWwJU2F0IE5v
 diAxNCAwOTowNDo1MSAyMDI2CkBAIC0xNCw2ICsxNCw3IEBACiAgICAgICA8bWV0aG9kX2NyZWRl
 bnRpYWwgdXNlcj0iQFRPUl9VU0VSQCIgZ3JvdXA9IkBUT1JfR1JPVVBAIi8+CiAgICAgPC9tZXRo
 b2RfY29udGV4dD4KICAgICA8ZXhlY19tZXRob2QgdHlwZT0ibWV0aG9kIiBuYW1lPSJzdGFydCIg
 ZXhlYz0iQFBSRUZJWEAvYmluL3RvciAtLVJ1bkFzRGFlbW9uIDEgLS1EYXRhRGlyZWN0b3J5IEBQ
 S0dfSE9NRUAiIHRpbWVvdXRfc2Vjb25kcz0iNjAiLz4KKyAgICA8ZXhlY19tZXRob2QgdHlwZT0i
 bWV0aG9kIiBuYW1lPSJyZWZyZXNoIiBleGVjPSI6a2lsbCAtSFVQIiB0aW1lb3V0X3NlY29uZHM9
 IjYwIi8+CiAgICAgPGV4ZWNfbWV0aG9kIHR5cGU9Im1ldGhvZCIgbmFtZT0ic3RvcCIgZXhlYz0i
 OmtpbGwiIHRpbWVvdXRfc2Vjb25kcz0iNjAiLz4KICAgICA8cHJvcGVydHlfZ3JvdXAgbmFtZT0i
 c3RhcnRkIiB0eXBlPSJmcmFtZXdvcmsiPgogICAgICAgPHByb3B2YWwgbmFtZT0iZHVyYXRpb24i
 IHR5cGU9ImFzdHJpbmciIHZhbHVlPSJjb250cmFjdCIvPgo=
 -----------------------25dee1d8fed5b634c5fb3fd691d438f9--
 
 --------02379783de138e7b41af42ecb92375a3ad5e980401409a9ca43c128d7c5059f1
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 
 wrsEARYKAG0Fgmr4Lx8JEGn/HhZye8ZnRRQAAAAAABwAIHNhbHRAbm90YXRp
 b25zLm9wZW5wZ3Bqcy5vcmf/vxWdOqcc3DEjbJ6Utctu+H3JbQqPmu5tCcAU
 qgRjlhYhBC8XJiZFecpGxO/9pWn/HhZye8ZnAABvggD/ZMLDIhgu1JBsqwxL
 gjmHKuVTFhC4Klpci1DeOcDplCgBANPE9wHEvYEgqiQBgTKBqBA9InAxbxZy
 8oNzhuV0YGcH
 =NcxA
 -----END PGP SIGNATURE-----
 
 
 --------02379783de138e7b41af42ecb92375a3ad5e980401409a9ca43c128d7c5059f1--
 



Home | Main Index | Thread Index | Old Index