PR/57517 CVS commit: pkgsrc/mk/buildlink3

["David A. Holland" <dholland%netbsd.org@localhost>]

The following reply was made to PR pkg/57517; it has been noted by GNATS.

From: "David A. Holland" <dholland%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/57517 CVS commit: pkgsrc/mk/buildlink3
Date: Sun, 1 Nov 2026 23:17:04 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Sun Nov  1 23:17:04 UTC 2026
 
 Modified Files:
 	pkgsrc/mk/buildlink3: bsd.buildlink3.mk
 
 Log Message:
 bsd.buildlink.mk: add hack/workaround for PR 57517
 
 Something, at some point, some years back, changed the interaction of
 things such that for builtin packages, BUILDLINK_PREFIX.pkg gets set
 before we're done assessing whether to use the builtin package, and in
 particular before the logic that makes USE_BUILTIN.pkg=no transitive
 across deps.
 
 The result has been that when this logic sets USE_BUILTIN.pkg=no, it's
 ignored and we buildlink and use the builtin package anyway. This then
 results in broken builds of things like fontconfig and Xft2 where this
 matters.
 
 As a workaround, clear BUILDLINK_PREFIX.pkg if we set USE_BUILTIN.pkg
 to no in this logic. It will then get set to PKGBASE as needed later.
 
 Strengthen the comments in and around this logic too, as what it does
 is itself somewhat complicated and confusing and the implementation
 is more so.
 
 ("Transitive across deps" means that if there's a builtin package A
 that we're not using, and a package B that depends on A, we can't use
 the builtin B either.)
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.266 -r1.267 pkgsrc/mk/buildlink3/bsd.buildlink3.mk
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.