pkg/60434: security/mit-krb5 uses invalid -Wunused-but-set-variable

["rwhitlock22%gmail.com@localhost via gnats" <gnats-admin%NetBSD.org@localhost>]

>Number:         60434
>Category:       pkg
>Synopsis:       security/mit-krb5 uses invalid -Wunused-but-set-variable
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 10 02:25:00 +0000 2026
>Originator:     Robert Whitlock
>Release:        pkgsrc current, July 9, 2026
>Organization:
>Environment:
Darwin robs-MacBook-Pro.local 20.6.0 Darwin Kernel Version 20.6.0: Thu Jul  6 22:12:47 PDT 2023; root:xnu-7195.141.49.702.12~1/RELEASE_X86_64 x86_64
>Description:
Building security/mit-krb5 on Mac OS X results in a failure because of an unknown -Wunused-but-set-variable option.
>How-To-Repeat:
$ MAKE_JOBS=1 bmake install
=> Bootstrap dependency digest>=20211023: found digest-20220214
WARNING: [license.mk] Every package should define a LICENSE.
===> _pkgformat-check-vulnerable [mit-krb5-1.22.2] ===> Skipping vulnerability checks.
WARNING: No /Users/rob/pkgsrcdir/current/pkg/pkgdb/pkg-vulnerabilities file found.
WARNING: To fix run: `/Users/rob/pkgsrcdir/current/pkg/sbin/pkg_admin -K /Users/rob/pkgsrcdir/current/pkg/pkgdb fetch-pkg-vulnerabilities'.
===> build-message [mit-krb5-1.22.2] ===> Building for mit-krb5-1.22.2
(cd include && /Users/rob/pkgsrcdir/current/pkg/bin/bmake autoconf.h osconf.h)
`autoconf.h' is up to date.
`osconf.h' is up to date.
making generate-files-mac in util...
making generate-files-mac in util/support...
making generate-files-mac in util/et...
making generate-files-mac in util/ss...
making generate-files-mac in util/profile...
making generate-files-mac in util/profile/testmod...
making generate-files-mac in util/verto...
making generate-files-mac in include...
(cd ../lib/krb5/error_tables && /Users/rob/pkgsrcdir/current/pkg/bin/bmake includes)
: ../lib/krb5/error_tables/krb5_err.h
: ../lib/krb5/error_tables/k5e1_err.h
: ../lib/krb5/error_tables/kdb5_err.h
: ../lib/krb5/error_tables/kv5m_err.h
: ../lib/krb5/error_tables/krb524_err.h
: ../lib/krb5/error_tables/asn1_err.h
making generate-files-mac in lib...
making generate-files-mac in lib/crypto...
making generate-files-mac in lib/crypto/krb...
making generate-files-mac in lib/crypto/builtin...
making generate-files-mac in lib/crypto/builtin/camellia...
making generate-files-mac in lib/crypto/builtin/des...
making generate-files-mac in lib/crypto/builtin/aes...
making generate-files-mac in lib/crypto/builtin/md4...
making generate-files-mac in lib/crypto/builtin/md5...
making generate-files-mac in lib/crypto/builtin/sha1...
making generate-files-mac in lib/crypto/builtin/sha2...
making generate-files-mac in lib/crypto/builtin/enc_provider...
making generate-files-mac in lib/crypto/builtin/hash_provider...
making generate-files-mac in lib/crypto/openssl...
making generate-files-mac in lib/crypto/openssl/des...
making generate-files-mac in lib/crypto/openssl/enc_provider...
making generate-files-mac in lib/crypto/openssl/hash_provider...
making generate-files-mac in lib/crypto/crypto_tests...
making generate-files-mac in lib/krb5...
making generate-files-mac in lib/krb5/error_tables...
making generate-files-mac in lib/krb5/asn.1...
making generate-files-mac in lib/krb5/ccache...
making generate-files-mac in lib/krb5/keytab...
making generate-files-mac in lib/krb5/krb...
making generate-files-mac in lib/krb5/os...
making generate-files-mac in lib/krb5/rcache...
making generate-files-mac in lib/krb5/unicode...
making generate-files-mac in lib/gssapi...
making generate-files-mac in lib/gssapi/generic...
making generate-files-mac in lib/gssapi/krb5...
making generate-files-mac in lib/gssapi/spnego...
making generate-files-mac in lib/gssapi/mechglue...
making generate-files-mac in lib/rpc...
making generate-files-mac in lib/rpc/unit-test...
making generate-files-mac in lib/kdb...
making generate-files-mac in lib/kadm5...
if [ -d ../../include/kadm5 ]; then :; else mkdir -p ../../include/kadm5; fi
for i in admin.h admin_internal.h admin_xdr.h kadm_rpc.h  server_internal.h ; do  i=`basename $i`;  if cmp ./$i ../../include/kadm5/$i >/dev/null 2>&1; then :;  else  (set -x; rm -f ../../include/kadm5/$i;  cp ./$i ../../include/kadm5/$i) ;  fi ;  done
for i in chpass_util_strings.h kadm_err.h ; do  i=`basename $i`;  if cmp $i ../../include/kadm5/$i >/dev/null 2>&1; then :;  else  (set -x; rm -f ../../include/kadm5/$i;  cp $i ../../include/kadm5/$i) ;  fi ;  done
making generate-files-mac in lib/kadm5/clnt...
if cmp ./client_internal.h  ../../../include/kadm5/client_internal.h >/dev/null 2>&1; then :;  else  (set -x; rm -f ../../../include/kadm5/client_internal.h;  cp ./client_internal.h  ../../../include/kadm5/client_internal.h) ;  fi
making generate-files-mac in lib/kadm5/srv...
making generate-files-mac in lib/apputils...
making generate-files-mac in lib/krad...
making generate-files-mac in plugins/audit...
making generate-files-mac in plugins/kdb/db2...
making generate-files-mac in plugins/kdb/db2/libdb2...
making generate-files-mac in plugins/kdb/db2/libdb2/hash...
making generate-files-mac in plugins/kdb/db2/libdb2/btree...
making generate-files-mac in plugins/kdb/db2/libdb2/db...
making generate-files-mac in plugins/kdb/db2/libdb2/mpool...
making generate-files-mac in plugins/kdb/db2/libdb2/recno...
making generate-files-mac in plugins/kdb/lmdb...
making generate-files-mac in plugins/preauth/otp...
making generate-files-mac in plugins/preauth/pkinit...
making generate-files-mac in plugins/preauth/spake...
making generate-files-mac in plugins/tls/k5tls...
making generate-files-mac in kdc...
making generate-files-mac in kadmin...
making generate-files-mac in kadmin/cli...
making generate-files-mac in kadmin/dbutil...
making generate-files-mac in kadmin/ktutil...
making generate-files-mac in kadmin/server...
making generate-files-mac in kprop...
making generate-files-mac in clients...
making generate-files-mac in clients/klist...
making generate-files-mac in clients/kinit...
making generate-files-mac in clients/kdestroy...
making generate-files-mac in clients/kpasswd...
making generate-files-mac in clients/ksu...
making generate-files-mac in clients/kvno...
Skipping missing directory clients/kcpytkt
Skipping missing directory clients/kdeltkt
making generate-files-mac in clients/kswitch...
making generate-files-mac in appl...
making generate-files-mac in appl/sample...
making generate-files-mac in appl/sample/sclient...
making generate-files-mac in appl/sample/sserver...
making generate-files-mac in appl/simple...
making generate-files-mac in appl/simple/client...
making generate-files-mac in appl/simple/server...
making generate-files-mac in appl/user_user...
making generate-files-mac in appl/gss-sample...
making generate-files-mac in config-files...
making generate-files-mac in build-tools...
making generate-files-mac in man...
making generate-files-mac in doc...
making generate-files-mac in po...
making all in util...
making all in util/support...
making all in util/et...
if cmp ./com_err.h  ../../include/com_err.h >/dev/null 2>&1; then :;  else  (set -x; rm -f ../../include/com_err.h;  cp ./com_err.h  ../../include/com_err.h) ;  fi
making all in util/ss...
making all in util/profile...
making all in util/profile/testmod...
making all in util/verto...
making all in include...
(cd ../lib/krb5/error_tables && /Users/rob/pkgsrcdir/current/pkg/bin/bmake includes)
: ../lib/krb5/error_tables/krb5_err.h
: ../lib/krb5/error_tables/k5e1_err.h
: ../lib/krb5/error_tables/kdb5_err.h
: ../lib/krb5/error_tables/kv5m_err.h
: ../lib/krb5/error_tables/krb524_err.h
: ../lib/krb5/error_tables/asn1_err.h
: db.h will be installed by util/db2
making all in lib...
making all in lib/crypto...
making all in lib/crypto/krb...
making all in lib/crypto/builtin...
making all in lib/crypto/builtin/camellia...
making all in lib/crypto/builtin/des...
making all in lib/crypto/builtin/aes...
making all in lib/crypto/builtin/md4...
making all in lib/crypto/builtin/md5...
making all in lib/crypto/builtin/sha1...
making all in lib/crypto/builtin/sha2...
making all in lib/crypto/builtin/enc_provider...
making all in lib/crypto/builtin/hash_provider...
making all in lib/crypto/openssl...
making all in lib/crypto/openssl/des...
making all in lib/crypto/openssl/enc_provider...
making all in lib/crypto/openssl/hash_provider...
making all in lib/crypto/crypto_tests...
making all in lib/krb5...
making all in lib/krb5/error_tables...
making all in lib/krb5/asn.1...
making all in lib/krb5/ccache...
making all in lib/krb5/keytab...
making all in lib/krb5/krb...
libtool --mode=compile clang -DHAVE_CONFIG_H -DLIBDIR=\"/Users/rob/pkgsrcdir/current/pkg/lib\" -DDYNOBJEXT=\".so\" -I../../../include -I../../../include -I./../os -I../../..  -DKRB5_DEPRECATED=1  -DKRB5_PRIVATE  -I/Users/rob/pkgsrcdir/current/pkg/include -O2 -I/Users/rob/pkgsrcdir/current/pkg/include -fno-common -Werror=unknown-warning-option -Wall -Wcast-align -Wshadow -Wmissing-prototypes -Wno-format-zero-length -Woverflow -Wstrict-overflow -Wmissing-format-attribute -Wmissing-prototypes -Wreturn-type -Wmissing-braces -Wparentheses -Wswitch -Wunused-function -Wunused-label -Wunused-variable -Wunused-value -Wunknown-pragmas -Wsign-compare -Wnewline-eof -Werror=uninitialized -Werror=pointer-arith -Werror=int-conversion -Werror=incompatible-pointer-types -Werror=implicit-int -Werror=strict-prototypes -Werror=declaration-after-statement -Werror-implicit-function-declaration   -c deltat.c
libtool: compile:  clang -DHAVE_CONFIG_H -DLIBDIR=\"/Users/rob/pkgsrcdir/current/pkg/lib\" -DDYNOBJEXT=\".so\" -I../../../include -I./../os -I../../.. -DKRB5_DEPRECATED=1 -DKRB5_PRIVATE -I/Users/rob/pkgsrcdir/current/wrkobjdir/security/mit-krb5/work/.buildlink/include -O2 -fno-common -Werror=unknown-warning-option -Wall -Wcast-align -Wshadow -Wmissing-prototypes -Wno-format-zero-length -Woverflow -Wstrict-overflow -Wmissing-format-attribute -Wmissing-prototypes -Wreturn-type -Wmissing-braces -Wparentheses -Wswitch -Wunused-function -Wunused-label -Wunused-variable -Wunused-value -Wunknown-pragmas -Wsign-compare -Wnewline-eof -Werror=uninitialized -Werror=pointer-arith -Werror=int-conversion -Werror=incompatible-pointer-types -Werror=implicit-int -Werror=strict-prototypes -Werror=declaration-after-statement -Werror-implicit-function-declaration -c deltat.c  -fno-common -DPIC -o .libs/deltat.o
x-deltat.y:47:32: error: unknown warning group '-Wunused-but-set-variable', ignored [-Werror,-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wunused-but-set-variable"
                               ^
1 error generated.
*** Error code 1

Stop.
bmake[3]: stopped making "all" in /Users/rob/pkgsrcdir/current/wrkobjdir/security/mit-krb5/work/krb5-1.22.2/src/lib/krb5/krb
*** Error code 1

Stop.
bmake[2]: stopped making "all" in /Users/rob/pkgsrcdir/current/wrkobjdir/security/mit-krb5/work/krb5-1.22.2/src/lib/krb5
*** Error code 1

Stop.
bmake[1]: stopped making "all" in /Users/rob/pkgsrcdir/current/wrkobjdir/security/mit-krb5/work/krb5-1.22.2/src/lib
*** Error code 1

Stop.
bmake: stopped making "generate-files-mac all" in /Users/rob/pkgsrcdir/current/wrkobjdir/security/mit-krb5/work/krb5-1.22.2/src
*** Error code 1

Stop.
bmake[1]: stopped making "install" in /Users/rob/pkgsrcdir/current/pkgsrc/security/mit-krb5
*** Error code 1

Stop.
bmake: stopped making "install" in /Users/rob/pkgsrcdir/current/pkgsrc/security/mit-krb5

>Fix: