pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/59702: sysutils/btop: multiple issues in btop-1.4.5



The following reply was made to PR pkg/59702; it has been noted by GNATS.

From: RVP <rvp%SDF.ORG@localhost>
To: Thomas Klausner <wiz%gatalith.at@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: pkg/59702: sysutils/btop: multiple issues in btop-1.4.5
Date: Fri, 17 Oct 2025 23:47:06 +0000 (UTC)

 On Thu, 16 Oct 2025, Thomas Klausner wrote:
 
 > The build steps use lots of colors, and after installing the man page,
 > the foreground color stays in a light grey.
 >
 > Running btop itself is fine, I'm only talking about the build. I'll
 > attach a screenshot.
 >
 
 Ah, I see now... The Makefile isn't turning off SGR in the `install' printfs:
 
 ```
 @printf "\033[1;92mInstalling doc to: \033[1;97m$(DESTDIR)$(PREFIX)/share/btop\n"
 ```
 
 Just tack on a `\033[0m' or `\033[m' before the final `\n'. I didn't notice this
 because my PS1 has colours, and the final escape in that is `\033[0m'. Plus,
 this looks terminal dependent too. In both xterm(1) and st(1) (on -HEAD),
 `\033[1;97m' just turns on bold _foreground_ (as it should) which isn't _that_
 noticeable.
 
 > I've committed a version of your patch, thank you!
 >
 
 Lovely!
 
 -RVP
 


Home | Main Index | Thread Index | Old Index