pkg/59619: textproc/lowdown: Compilation on Darwin

[db7%mini.fritz.box@localhost]

>Number:         59619
>Category:       pkg
>Synopsis:       Failing compilation of lowdown 2.0.2 on Darwin
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Aug 30 13:15:00 +0000 2025
>Originator:     db7%mini.fritz.box@localhost
>Release:        Darwin 24.6.0
>Organization:
>Environment:
System: Darwin mini 24.6.0 Darwin Kernel Version 24.6.0: Mon Jul 14 11:30:34 PDT 2025; root:xnu-11417.140.69~1/RELEASE_ARM64_T8103 arm64


>Description:
	With latest version of pkgsrc, the package textproc/lowdown (v2.0.2) does not compile properly.
	The original Makefile sets the symbol visibility to hidden and that causes some compatibility
	functions to "disappear" when linking the final binary.
>How-To-Repeat:
>Fix:
	The following patch removes the visibility=hidden option from Makefile for OPSYS = Darwin:
	
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/lowdown/Makefile,v
retrieving revision 1.34
diff -u -p -r1.34 Makefile
--- Makefile	6 Jun 2025 23:10:26 -0000	1.34
+++ Makefile	30 Aug 2025 13:01:40 -0000
@@ -4,6 +4,7 @@ DISTNAME=		lowdown-2.0.2
 CATEGORIES=		textproc
 MASTER_SITES=		${MASTER_SITE_GITHUB:=kristapsdz/}
 GITHUB_TAG=		refs/tags/VERSION_${PKGVERSION_NOREV:S/./_/g}
+PKGREVISION=		1
 
 MAINTAINER=		pkgsrc-users%NetBSD.org@localhost
 HOMEPAGE=		https://kristaps.bsd.lv/lowdown/
@@ -32,4 +33,13 @@ TEST_TARGET=		regress
 pre-configure:
 	${ECHO} HAVE_SANDBOX_INIT=0 >> ${WRKSRC}/configure.local
 
+.include "../../mk/bsd.prefs.mk"
+.if ${OPSYS} == "Darwin"
+SUBST_CLASSES+=		hidden
+SUBST_SED.hidden+=	-e '/^CFLAGS.*visibility=hidden.*/d'
+SUBST_FILES.hidden=	Makefile
+SUBST_STAGE.hidden=	pre-build
+SUBST_MESSAGE.hidden=	Removing hidden visibility of symbols
+.endif
+
 .include "../../mk/bsd.pkg.mk"