Re: pkg/59609 (zstandard-0.24.0 seems to unconditionally access qsort_r() that may not be available on older NetBSD)

["Leonardo Taccari via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR pkg/59609; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/59609 (zstandard-0.24.0 seems to unconditionally access qsort_r() that may not be available on older NetBSD)
Date: Tue, 26 Aug 2025 16:36:12 +0200

 Hello Thomas,
 
 Thomas Klausner via gnats writes:
 > The following reply was made to PR pkg/59609; it has been noted by GNATS.
 >
 > From: Thomas Klausner <wiz%netbsd.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: 
 > Subject: Re: pkg/59609 (zstandard-0.24.0 seems to unconditionally access
 >  qsort_r() that may not be available on older NetBSD)
 > Date: Tue, 26 Aug 2025 16:03:58 +0200
 >
 >  --ifhvsxyg77eouv7s
 >  Content-Type: text/plain; charset=us-ascii
 >  Content-Disposition: inline
 >  
 >  Please try the attached diff and add the appropriate NetBSD version
 >  check so it triggers for you - this is fine in NetBSD 11 and late
 >  10.99.x.
 >   Thomas
 >  
 >  --ifhvsxyg77eouv7s
 >  Content-Type: text/plain; charset=us-ascii
 >  Content-Disposition: attachment; filename="zstd.diff"
 >  
 >  Index: Makefile
 >  ===================================================================
 >  RCS file: /cvsroot/pkgsrc/archivers/py-zstandard/Makefile,v
 >  retrieving revision 1.36
 >  diff -u -r1.36 Makefile
 >  --- Makefile	17 Aug 2025 20:43:58 -0000	1.36
 >  +++ Makefile	26 Aug 2025 14:02:16 -0000
 >  @@ -16,6 +16,8 @@
 >   
 >   USE_TOOLS+=	cpp
 >   
 >  +CPPFLAGS+=	-DZDICT_QSORT=ZDICT_QSORT_C90
 >  +
 >   # upstream prefers to use its bundled version of zstd
 >   # https://github.com/indygreg/python-zstandard/blob/0063333790a853360c816101511635865405834f/c-ext/backend_c.c#L137-L151
 >   #BUILDLINK_API_DEPENDS.zstd+=	zstd>=1.5.7
 >  
 >  --ifhvsxyg77eouv7s--
 >  
 
 I can confirm that this patch fixes it.
 
 I have committed the patch and limited to NetBSD<11.0 per qsort_r(3) (I
 have not inspected in which 10.99.x was added: that's suboptimal but at
 the same time should be fine also to 10.99.x that have qsort_r()).
 
 I have also bumped the PKGREVISION given that it previous built fine
 despite that.
 
 
 Thanks a lot Thomas!