pkg/59577: net/dtorrent fails on darwin>15

[sotiris%lamprinidis.com@localhost]

>Number:         59577
>Category:       pkg
>Synopsis:       net/dtorrent fails on darwin>15
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 06 13:45:00 +0000 2025
>Originator:     Sotiris Lamprinidis
>Release:        pkgsrc-2025Q2
>Organization:
>Environment:
Darwin 24.5.0 Darwin Kernel Version 24.5.0: Tue Apr 22 19:54:49 PDT 2025; root:xnu-11417.121.6~2/RELEASE_ARM64_T6000 arm64

>Description:
Building the package fails with:

In file included from compat.c:11:                                                                                                                                                                                     
./compat.h:23:13: error: typedef redefinition with different types ('int' vs 'enum clockid_t')             
   23 | typedef int clockid_t;                                                                             
      |             ^                                                                                      
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.5.sdk/usr/include/_time.h:175:3: note: previous definition is here
  175 | } clockid_t;                                                                                       
      |   ^        

`clock_gettime` (and `clockid_t`) "first appeared in Mac OSX 10.12" (from the man page).

I guess this is an upstream bug, but seeing the package has been last updated at 2008, do as you will with this info.
>How-To-Repeat:

>Fix:
--- net/dtorrent/Makefile.orig  2025-08-06 15:31:42.532193667 +0200
+++ net/dtorrent/Makefile       2025-08-06 15:32:15.448901764 +0200
@@ -20,6 +20,12 @@
 
 CONFIGURE_ARGS+=       --with-ssl=${SSLBASE}
 
+.include "../../mk/bsd.prefs.mk"
+
+.if ${OPSYS} == "Darwin" && ${OS_VERSION:R} > 15
+CFLAGS+= -DHAVE_CLOCKID_T
+.endif
+
 DOCDIR=                        share/doc/ctorrent
 
 INSTALLATION_DIRS=     ${DOCDIR}