pkg/59509: netatalk4 broken

[christos%astron.com@localhost]

>Number:         59509
>Category:       pkg
>Synopsis:       netatalk4 is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 04 22:55:00 +0000 2025
>Originator:     Christos Zoulas
>Release:        NetBSD 10.99.12
>Organization:
	Rotten Apples, Inc.
>Environment:
System: NetBSD saturn.astron.com 10.99.12 NetBSD 10.99.12 (SATURN) #0: Sat Nov 23 12:49:47 EST 2024 christos%quasar.astron.com@localhost:/usr/src/sys/arch/amd64/compile/SATURN amd64
Architecture: x86_64
Machine: amd64
>Description:

There is a "special" hack in util.h that makes NetBSD load modules
with RTLD_LAZY. Well, yes this appears to work, but does not really
work since symbols from pam don't get resolved. 
	
>How-To-Repeat:
	Try to mount a share with afpd. Notice in /var/log/debug:
Jul  4 10:27:38 saturn afpd: in try_dlopen(): /usr/lib/security/pam_skey.so.4: /usr/lib/security/pam_skey.so.4: Undefined PLT symbol "pam_error" (symnum = 1)
Jul  4 10:27:38 saturn afpd: in openpam_load_module(): no pam_skey.so found
>Fix:
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ patches/patch-include_atalk_util.h  4 Jul 2025 22:39:49 -0000
@@ -0,0 +1,11 @@
+--- include/atalk/util.h.orig  2025-07-04 10:23:35.330324979 -0400
++++ include/atalk/util.h       2025-07-04 10:23:50.613808953 -0400
+@@ -122,7 +122,7 @@
+  * OpenBSD currently does not use the second arg for dlopen(). For
+  * future compatibility we define DL_LAZY */
+ #ifdef __NetBSD__
+-#define mod_open(a)      dlopen(a, RTLD_LAZY)
++#define mod_open(a)      dlopen(a, RTLD_NOW|RTLD_GLOBAL)
+ #elif defined(__OpenBSD__)
+ #define mod_open(a)      dlopen(a, DL_LAZY)
+ #else /* ! __NetBSD__ && ! __OpenBSD__ */