pkg/59488: net/tcptrace does not build (amd64 HEAD)

[kre%munnari.OZ.AU@localhost]

>Number:         59488
>Category:       pkg
>Synopsis:       net/tcptrace does not build (amd64 HEAD)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 28 12:45:00 +0000 2025
>Originator:     Robert Elz
>Release:        NetBSD 10.99.14
>Organization:
>Environment:
System: NetBSD jacaranda.noi.kre.to 10.99.14 NetBSD 10.99.14 (JACARANDA:1.1-20250525) #200: Sun May 25 10:04:09 +07 2025 kre%jacaranda.noi.kre.to@localhost:/usr/obj/testing/kernels/amd64/JACARANDA amd64
Architecture: x86_64
Machine: amd64
>Description:
	The function pread_tcpdump() in tcptrace/tcpdump.c attempts to call
	pcap_offline_read() to read a packet from a saved pcap file.

	The function in libpcap is actually called pcapint_offline_read()
	(at least it is in libpcap 1.10.5 -- which is what is in both pkgsrc
	net/libpcap, and HEAD).   Needless to say, calling a function which
	does not exist in the library results in an undefined symbol linker
	error.

>How-To-Repeat:
	cd ..../pkgsrc/net/tcptrace
	make package-install

>Fix:
	In pkgsrc/net/tcptrace/patches/patch-tcpdump.c add changes to alter
	pcap_offline_read() into pcapint_offline_read() which is the function
	(with the same obviously desired semantics and signature) instead.

	Note that there is both an extern decl for pcap_offline_read() and
	exactly one call of that function (in pread_tcpdump()).  Whether the
	extern declaration remains required or not, I did not test, I did
	verify that it builds with just this one change (applied in both
	sites pcap_offline_read is mentioned).

	Note though that I edited the unpacked source to make it, rather
	than altering the patch.