PR/59399 CVS commit: pkgsrc/net/scamper

["Thomas Klausner" <wiz%netbsd.org@localhost>]

The following reply was made to PR pkg/59399; it has been noted by GNATS.

From: "Thomas Klausner" <wiz%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/59399 CVS commit: pkgsrc/net/scamper
Date: Tue, 6 May 2025 07:28:05 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Tue May  6 07:28:05 UTC 2025
 
 Modified Files:
 	pkgsrc/net/scamper: Makefile distinfo
 
 Log Message:
 scamper: update to 20250505.
 
 Provided by mjl in PR 59399.
 
 20250505:
 
 scamper:
 * trace: separate probes from replies
 * trace: support -P tcp-ack Path MTU probing
 * trace: support -N squeries with Path MTU probing
 * trace: embed path MTU probing data in JSON output
 * ping: add -O dltx option to force datalink tx, capture nhmtu in
   ICMP PTB messages
 * add basic sysctl-like configuration file support, which currently
   only allows for disabling measurement primitives, e.g.:
   # disable udpprobe measurement primitive
   udpprobe.enable=0
 * hopefully fix build on solaris
 
 libscamperfile:
 * chase separation of traceroute probes from replies, add
   scamper_trace_hopiter_* to simplify required user code
   modifications.
 * fix 20250227 regression that did not read ipid32 in ping replies
   correctly, which lead to speedtrap not working.
 * fix udpprobe warts storage when no packets are sent.
 * be defensive allocating memory in warts read path.
 * be defensive with possible null pointers when generating json from
   malformed warts.
 * bump libscamperfile version.
 
 Python module:
 * include setup.py in source code distribution.
 * transparently handle separation of traceroute probes from replies.
 * extend do_ping to support MTU probing, and capture embedded nhmtu.
 
 tests:
 * replace unit_host_warts, unit_http_warts, unit_ping_warts,
   unit_trace_warts, unit_udpprobe_warts, with unit_warts.
 * expand ping warts unit tests to check ipid values.
 * expand trace warts unit tests to include last ditch probing, and
   path mtu discovery.
 * add udpprobe and dealias warts unit tests.
 * add fuzz_warts2json.
 * add simple unit tests for parsing scamper configuration file.
 
 throughout:
 * chase libscamperfile modifications throughout bundled utilities.
 * use string_concatc in all obvious places, reduce use of
   string_concaf further, speeding up string rendering.
 
 20250401:
 
 scamper:
 * move items that require privilege (opening files, unlinking files,
   opening raw sockets, datalink interfaces) into scamper_priv.c and
   have each follow a consistent pattern.  previously these were
   distributed throughout many source code files.
 * add build option that allows scamper to decide if it will do
   privilege separation at run time.
   the --enable-scamper-privsep=rootonly configure option enables this
   behavior.  if run with root privileges, scamper will do privilege
   separation.  if not run with root privileges, scamper will not.
   --enable-scamper-privsep=yes (the default) does privilege separation
   regardless of root privilege status.
   note: the previous --disable-privsep configure option has become
   --disable-scamper-privsep
 * restructure the way that blocked tasks (tasks that share a probe
   signature) are handled
 * add -O mss=foo option to ping, which will include mss option to
   TCP syn probe methods.
 * ignore packets on the datalink interface associated with a probe
   that has a timestamp after the datalink packet's timestamp.
 * increase scamper -H holdtime limit from 10s to 60s.
 
 python module:
 * add ScamperCtrl.outfile setter
 * fix ScamperFile filter_types
 
 libscamperfile:
 * handle termination HTTP chunk correctly (noticed running unit tests
   on MacOS, which has a stricter strtol)
 * be more accepting when processing HTTP headers
 
 libscamperctrl:
 * fix bug when reading partial control messages from mux
 
 tests:
 * add unit test for prefixtree implementation
 * add tests for parsing HTTP headers
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.21 -r1.22 pkgsrc/net/scamper/Makefile
 cvs rdiff -u -r1.18 -r1.19 pkgsrc/net/scamper/distinfo
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.