Re: pkg/59205 (graphics/librsvg is missing dependencies)

[riastradh%NetBSD.org@localhost]

Synopsis: graphics/librsvg is missing dependencies

State-Changed-From-To: open->analyzed
State-Changed-By: riastradh%NetBSD.org@localhost
State-Changed-When: Sat, 22 Mar 2025 14:19:23 +0000
State-Changed-Why:
Here's what's happening:

1. graphics/librsvg pulls in lang/rust/cargo.mk.
2. lang/rust/cargo.mk adds USE_TOOLS+=digest.
3. The `Set the type of dependency' logic in mk/tools/replace.mk sets
   _TOOLS_DEPMETHOD.digest=TOOL_DEPENDS _but not_ BOOTSTRAP_DEPENDS.
4. The fetch phase pulls in BOOTSTRAP_DEPENDS _but not_ TOOL_DEPENDS.
5. Now digest is not installed but the fetch phase needs it.

Other packages, like net/socat, don't have USE_TOOLS+=digest, so
_TOOLS_DEPMETHOD.digest=BOOTSTRAP_DEPENDS and the fetch phase works out
fine.

I think maybe the _TOOLS_DEPMETHOD.${...} assignments in
mk/tools/replace.mk should be with ?= rather than =, or be done in the
opposite order, so that dependencies are put in the _earliest_ stage
where they are needed, rather than the _latest_.

Except that doesn't work for USE_TOOLS+=...:run which needs to go in
DEPENDS which affects the _run-time_ package not the _build-time_
environment -- which, really, I think is a design mistake that we
should fix by just eliminating USE_TOOLS+=...:run altogether; it's
incompatible with cross-compilation.  But for now, maybe the _other_
_TOOLS_DEPMETHOD.${...} assignments should be done with ?=.