pkg/59104: pkgsrc wine-9.0 cannot find DLLs

[netbsd%singularity.org.uk@localhost]

>Number:         59104
>Category:       pkg
>Synopsis:       pkgsrc wine-9.0 cannot find DLLs
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 25 16:45:00 +0000 2025
>Originator:     Graham Willmott
>Release:        pkgsrc current 2025-02-01
>Organization:
>Environment:
NetBSD arc.singularity.org.uk 10.99.12 NetBSD 10.99.12 (ARC) #0: Thu Dec 12 13:35:57 GMT 2024  graham%arc.singularity.org.uk@localhost:/home/graham/sysbuild/amd64/obj/usr/src/sys/arch/amd64/compile/ARC amd64
>Description:
Wine 9.0 builds OK but does not run any Windows applications other than the simple internal programs like notepad and winecfg. Programs requiring DLLs to be loaded fail with a "DLL not found" error in the Wine debug output.

This is caused by Wine incorrectly believing the filesystem is case-insensitive and therefore not performing the correct filename translation when searching for DLLs.

The root cause is that the strncmp call used to check the filesystem type in ntdll/unix/file.c uses the wrong logic.
>How-To-Repeat:
wine64 <almost-any-program>.exe
>Fix:

--- dlls/ntdll/unix/file.c.orig	2024-01-16 20:55:47.000000000 +0000
+++ dlls/ntdll/unix/file.c
@@ -1238,8 +1238,8 @@ static BOOLEAN get_dir_case_sensitivity_
 
     if (statvfs( dir, &stfs ) == -1) return TRUE;
     /* Only assume CIOPFS is case insensitive. */
-    if (strcmp( stfs.f_fstypename, "fusefs" ) ||
-        strncmp( stfs.f_mntfromname, "ciopfs", 5 ))
+    if (!strcmp( stfs.f_fstypename, "fusefs" ) &&
+        !strncmp( stfs.f_mntfromname, "ciopfs", 5 ))
         return FALSE;
     return TRUE;