Re: pkg/58475: devel/py-cython build fails due to lang/python312 includes using C99 features

[Phil Krylov <phil+netbsd%krylov.eu@localhost>]

The following reply was made to PR pkg/58475; it has been noted by GNATS.

From: Phil Krylov <phil+netbsd%krylov.eu@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: Thomas Klausner <wiz%NetBSD.org@localhost>
Subject: Re: pkg/58475: devel/py-cython build fails due to lang/python312
 includes using C99 features
Date: Sun, 28 Jul 2024 13:49:17 +0200

 On 2024-07-27 17:45, Thomas Klausner wrote:
 >  The buildlink file is not the appropriate place for this.  A
 >  dependency might prefer c11, but this would force it down to c99.
 > 
 >  This needs to be fixed where it happens, in this case in py-cython.
 
 OK, you're right! Here is an updated patch:
 
 Index: devel/py-cython/Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/py-cython/Makefile,v
 retrieving revision 1.93
 diff -p -u -r1.93 Makefile
 --- devel/py-cython/Makefile	26 May 2024 01:59:19 -0000	1.93
 +++ devel/py-cython/Makefile	28 Jul 2024 11:38:08 -0000
 @@ -21,6 +21,13 @@ REPLACE_PYTHON+=	cython.py
 
   USE_CC_FEATURES=	c99
 
 +.include "../../lang/python/pyversion.mk"
 +.if ${PYTHON_VERSION} == "312"
 +# .buildlink/include/python3.12/internal/pycore_frame.h:134:5:
 +# error: 'for' loop initial declarations are only allowed in C99 mode
 +FORCE_C_STD+=		c99
 +.endif
 +
   PYTHON_VERSIONS_INCOMPATIBLE=	27
 
   post-install: