pkg/58457: devel/glib2 2.80+ build fails with GCC 4.8.5

[phil+netbsd%krylov.eu@localhost]

>Number:         58457
>Category:       pkg
>Synopsis:       devel/glib2 2.80+ build fails with GCC 4.8.5
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 23 00:30:01 +0000 2024
>Originator:     Phil Krylov
>Release:        pkgsrc-current
>Organization:
krylov.eu
>Environment:
Linux localhost.localdomain 3.10.0-1160.119.1.el7.x86_64 #1 SMP Tue Jun 4 14:43:51 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
>Description:
devel/glib2 build fails on CentOS 7 since 2.80.0 has arrived. The reason is a GCC bug:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54113

The full logs can be seen at:

https://us-central.manta.mnx.io/pkgsrc/public/reports/Linux/el7/trunk/x86_64/20240409.2239/glib2-2.80.0/build.log

and all later CentOS 7 builds on https://mail-index.netbsd.org/pkgsrc-bulk/ .

>How-To-Repeat:
bmake -C devel/glib2
>Fix:
Here is a patch:

Index: devel/glib2/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/glib2/Makefile,v
retrieving revision 1.305
diff -p -u -r1.305 Makefile
--- devel/glib2/Makefile        12 Jun 2024 10:15:59 -0000      1.305
+++ devel/glib2/Makefile        22 Jul 2024 22:29:03 -0000
@@ -87,6 +87,14 @@ PKGCONFIG_OVERRIDE_STAGE=    post-configure
 # to run gdbus-codegen to generate gdbus-daemon-generated.{h,c}
 PYTHON_FOR_BUILD_ONLY= yes

+.include "../../mk/compiler.mk"
+
+# Work around GCC 4.x bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54113
+# preventing a successful CentOS 7 build
+.if !empty(CC_VERSION:Mgcc-4.*)
+BUILDLINK_TRANSFORM+=   rm:-Werror=missing-prototypes
+.endif
+
 post-extract:
        ${CHMOD} +x ${WRKSRC}/gio/tests/gengiotypefuncs.py