Re: pkg/58285: qt6-qttools fails to build on NetBSD/amd64 10.0 user-land

[Niclas Rosenvik <nros%netbsd.org@localhost>]

On Sat, 25 May 2024 22:15:00 +0000 (UTC)
he%NetBSD.org@localhost wrote:

> >Description:
> 	I'm running a 10.99.4 kernel with (now) 10.0 user-land.
> 	For me, qt6-qttools fails to build, ref. pkg/58249, but
> 	this build failure deserves its own PR.
> 
> In file included from
> /usr/pkgsrc/devel/qt6-qttools/work/qttools-everywhere-src-6.7.0/src/assistant/qlitehtml/src/container_qpainter.cpp:5:
> /usr/pkgsrc/devel/qt6-qttools/work/qttools-everywhere-src-6.7.0/src/assistant/qlitehtml/src/container_qpainter_p.h:80:10:
> error: 'void
> DocumentContainerPrivate::draw_background(litehtml::uint_ptr, const
> std::vector<litehtml::background_paint>&)' marked 'override', but
> does not override 80 |     void draw_background(litehtml::uint_ptr
> hdc, |          ^~~~~~~~~~~~~~~

I have test built qt6-qttools 6.7.2 with litehtml 0.9 and it builds
fine on my machine (NetBSD 9) .
To me these error messages have nothing to do with NetBSD 10 userland
but the version of lithtml used.
Are you sure that you are building against litehtml 0.9 from pkgsrc?
litehtml has a commit (e455a0b50ff89b292193d247d3204384d9c46903) that
removes draw_background that is newer than litehtml 0.9 or are you
using litehtml 0.6? draw_background was introduced in litehtml 0.7 . So
litehtml is not API stable.

> >How-To-Repeat:
> 	Trying to build qt6-qttools-6.7.0.
> >Fix:
> 	Yes, please.
> 
Check the version of litehtml installed on your machine and make sure it
is litehtml 0.9 . If it is not update to 0.9 and try to build again.
That might fix it.