PR/58315 CVS commit: pkgsrc/mk

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR pkg/58315; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/58315 CVS commit: pkgsrc/mk
Date: Wed, 5 Jun 2024 17:17:21 +0000

 Module Name:	pkgsrc
 Committed By:	riastradh
 Date:		Wed Jun  5 17:17:21 UTC 2024
 
 Modified Files:
 	pkgsrc/mk: bsd.prefs.mk
 
 Log Message:
 bsd.prefs.mk: Work around Cygwin OBJECT_FMT mistake in bsd.own.mk.
 
 We should maybe isolate this OBJECT_FMT detection in a way that it
 can be written down once, not 2-3 times in bsd.prefs.mk and
 bsd.own.mk.
 
 Part of the reason it is duplicated now is because it is done
 separately for NATIVE_OBJECT_FMT (the object format used by native
 packages we're running) and OBJECT_FMT (the object format used by
 packages we're building, which may be cross-built).
 
 The same treatment may be required for AIX, OSF/1, and HP-UX, for
 which bsd.prefs.mk sets a non-ELF OBJECT_FMT, but for which
 bsd.own.mk appears to incorrectly set OBJECT_FMT=ELF too like it does
 for Cygwin and Darwin.
 
 No functional change intended on non-Cygwin platforms because this is
 conditional on ${NATIVE_OPSYS} == "Cygwin".
 
 PR pkg/58315: pkgsrc reports "object format ``PE'' which differs from ``ELF''" in cygwin
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.448 -r1.449 pkgsrc/mk/bsd.prefs.mk
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.