pkg/58060: www/nghttp2 needs c++ in USE_LANGUAGES when using clang

[sotiris%lamprinidis.com@localhost]

>Number:         58060
>Category:       pkg
>Synopsis:       www/nghttp2 needs c++ in USE_LANGUAGES when using clang
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 21 18:15:00 +0000 2024
>Originator:     Sotiris Lamprinidis
>Release:        NetBSD 10.0-RC6 / pkgsrc current 21 Mar 2024
>Organization:
>Environment:
NetBSD virt 10.0_RC6 NetBSD 10.0_RC6 (GENERIC64.202403191940Z) evbarm (in qemu)
>Description:
In www/nghttp2 Makefile there is this comment:
 > # Upstream documents that c++14 is required for C++ parts of the code;
 > # the base package does not use C++.
 > USE_LANGUAGES=          c

However, when using clang configure fails with
 > checking how to run the C++ preprocessor... /usr/bin/cpp
 > configure: error: in `/usr/pkgsrc/www/nghttp2/work/nghttp2-1.60.0':
 > configure: error: C++ preprocessor "/usr/bin/cpp" fails sanity check

as the appropriate wrapper is not created.

>How-To-Repeat:
make configure -C /usr/pkgsrc/www/nghttp2 on a system with non-existing /usr/bin/cpp
>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/www/nghttp2/Makefile,v
retrieving revision 1.85
diff -u -r1.85 Makefile
--- Makefile    21 Jan 2024 19:58:51 -0000      1.85
+++ Makefile    21 Mar 2024 18:10:00 -0000
@@ -6,7 +6,7 @@ ADD c++ to USE LANGUAGES
 
 # Upstream documents that c++14 is required for C++ parts of the code;
 # the base package does not use C++.
-USE_LANGUAGES=         c
+USE_LANGUAGES=         c c++
 USE_LIBTOOL=           yes
 USE_TOOLS+=            gmake pkg-config
 GNU_CONFIGURE=         yes