pkg/57823: libtool 2.4.7 causing ncurses build failure

[kludev%gmail.com@localhost]

>Number:         57823
>Category:       pkg
>Synopsis:       libtool 2.4.7 causing ncurses build failure
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 06 08:15:00 +0000 2024
>Originator:     KL
>Release:        pkgsrc git commit 0c1a9f271794cc4def803eb3485b0ed167ec23ba
>Organization:
>Environment:
Linux 5.19.0-32-generic #33~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Mon Jan 30 17:03:34 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

>Description:
making devel/ncurses failure with:

+ cd ../obj_lo
+ libtool --tag=CXX --silent --mode=compile c++ -DHAVE_CONFIG_H -DBUILDING_NCURSES_CXX -I../c++ -I. -I../include -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -DNDEBUG -O2 -c ../c++/demo.cc -o ../obj_lo/demo.lo
mv: 'demo.o' and '../obj_lo/demo.o' are the same file
make[1]: * [Makefile:268: ../obj_lo/demo.lo] Error 1 


Looking more, I found out several things: 

1. pkgsrc uses devel/libtool 2.4.7, which is not the stable release. 2.4.6 is the stable release. 
2. I replaced pkgsrc bin/libtool with my system's libtool 2.4.6, this time, pkgsrc build devel/ncurses succeeded.
3. I can reproduce this issue by building ncurses directly in my host system, without pkgsrc. So I have reported the bug to libtool, at https://savannah.gnu.org/support/?111002


Finally, I want to report the issue here, so that pkgsrc should use 2.4.6 as this is currently the stable release, as of Jan 5th, 2024 (see: https://www.gnu.org/software/libtool/)
>How-To-Repeat:
BMAKE="~/.local/bin/bmake"   # my pkgsrc install location

cd devel/ncurses &&
"$BMAKE"
>Fix:
cd ~/.local/bin  # my pkgsrc install location
mv libtool libtool.disable   # disable pkgsrc libtool 2.4.7
ln -s /bin/libtool .   # replace with system libtool 2.4.6

cd ~/work/pkgsrc/devel/ncurses
~/.local/bin/bmake   # success!