pkg/57693: graphics/GraphicsMagic won't build without brotli buildlink3.mk

[jdwhite%menelos.com@localhost]

>Number:         57693
>Category:       pkg
>Synopsis:       graphics/GraphicsMagick fails to build without brotli buildlink3.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 11 17:10:00 +0000 2023
>Originator:     System Administrator
>Release:        Darwin 23.1.0
>Organization:
Menelos LLC
>Environment:
System:  Darwin pkgbuild-arm.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:26:29 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_VMAPPLE arm64
System2: Darwin pkgbuild-x86.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:27:27 PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64

pkgsrc-current, tree updated 15:30 UTC November 11, 2023.

>Description:

Build of graphics/GraphicsMagic fails due to missing libbrotlidec. Same failure (and fix) on Darwin x86_64 and arm64.

During configure...

checking for freetype2... no
Package libbrotlidec was not found in the pkg-config search path.
Perhaps you should add the directory containing `libbrotlidec.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libbrotlidec', required by 'freetype2', not found
Package libbrotlidec was not found in the pkg-config search path.
Perhaps you should add the directory containing `libbrotlidec.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libbrotlidec', required by 'freetype2', not found
Package libbrotlidec was not found in the pkg-config search path.
Perhaps you should add the directory containing `libbrotlidec.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libbrotlidec', required by 'freetype2', not found
Package libbrotlidec was not found in the pkg-config search path.
Perhaps you should add the directory containing `libbrotlidec.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libbrotlidec', required by 'freetype2', not found

Freetype2 isn't found and neither is libbrotlidec, yet is passed to the linker:

[...]
libtool: link: clang -dynamiclib  -o magick/.libs/libGraphicsMagick.3.dylib  magick/.libs/libGraphicsMagick_la-analyze.o magick/.libs/libGraphicsMagick_la-annotate.o magick/.libs/libGraphicsMagick_la-attribute.o magick/.libs/libGraphicsMagick_la-average.o magick/.libs/libGraphicsMagick_la-bit_stream.o magick/.libs/libGraphicsMagick_la-blob.o magick/.libs/libGraphicsMagick_la-cdl.o magick/.libs/libGraphicsMagick_la-channel.o magick/.libs/libGraphicsMagick_la-compare.o magick/.libs/libGraphicsMagick_la-confirm_access.o magick/.libs/libGraphicsMagick_la-color.o magick/.libs/libGraphicsMagick_la-color_lookup.o magick/.libs/libGraphicsMagick_la-colormap.o magick/.libs/libGraphicsMagick_la-colorspace.o magick/.libs/libGraphicsMagick_la-command.o magick/.libs/libGraphicsMagick_la-composite.o magick/.libs/libGraphicsMagick_la-compress.o magick/.libs/libGraphicsMagick_la-constitute.o magick/.libs/libGraphicsMagick_la-decorate.o magick/.libs/libGraphicsMagick_la-delegate.o magick/.libs/libGrap
 hicsMagick_la-deprecate.o magick/.libs/libGraphicsMagick_la-describe.o magick/.libs/libGraphicsMagick_la-draw.o magick/.libs/libGraphicsMagick_la-effect.o magick/.libs/libGraphicsMagick_la-enhance.o magick/.libs/libGraphicsMagick_la-enum_strings.o magick/.libs/libGraphicsMagick_la-error.o magick/.libs/libGraphicsMagick_la-export.o magick/.libs/libGraphicsMagick_la-floats.o magick/.libs/libGraphicsMagick_la-fx.o magick/.libs/libGraphicsMagick_la-gem.o magick/.libs/libGraphicsMagick_la-gradient.o magick/.libs/libGraphicsMagick_la-hclut.o magick/.libs/libGraphicsMagick_la-image.o magick/.libs/libGraphicsMagick_la-import.o magick/.libs/libGraphicsMagick_la-list.o magick/.libs/libGraphicsMagick_la-locale.o magick/.libs/libGraphicsMagick_la-log.o magick/.libs/libGraphicsMagick_la-magic.o magick/.libs/libGraphicsMagick_la-magick.o magick/.libs/libGraphicsMagick_la-magick_endian.o magick/.libs/libGraphicsMagick_la-map.o magick/.libs/libGraphicsMagick_la-memory.o magick/.libs/libGraphicsMagi
 ck_la-module.o magick/.libs/libGraphicsMagick_la-monitor.o magick/.libs/libGraphicsMagick_la-montage.o magick/.libs/libGraphicsMagick_la-omp_data_view.o magick/.libs/libGraphicsMagick_la-operator.o magick/.libs/libGraphicsMagick_la-paint.o magick/.libs/libGraphicsMagick_la-pixel_cache.o magick/.libs/libGraphicsMagick_la-pixel_iterator.o magick/.libs/libGraphicsMagick_la-plasma.o magick/.libs/libGraphicsMagick_la-profile.o magick/.libs/libGraphicsMagick_la-quantize.o magick/.libs/libGraphicsMagick_la-registry.o magick/.libs/libGraphicsMagick_la-random.o magick/.libs/libGraphicsMagick_la-render.o magick/.libs/libGraphicsMagick_la-resize.o magick/.libs/libGraphicsMagick_la-resource.o magick/.libs/libGraphicsMagick_la-segment.o magick/.libs/libGraphicsMagick_la-semaphore.o magick/.libs/libGraphicsMagick_la-shear.o magick/.libs/libGraphicsMagick_la-signature.o magick/.libs/libGraphicsMagick_la-static.o magick/.libs/libGraphicsMagick_la-statistics.o magick/.libs/libGraphicsMagick_la-tempf
 ile.o magick/.libs/libGraphicsMagick_la-texture.o magick/.libs/libGraphicsMagick_la-timer.o magick/.libs/libGraphicsMagick_la-transform.o magick/.libs/libGraphicsMagick_la-tsd.o magick/.libs/libGraphicsMagick_la-type.o magick/.libs/libGraphicsMagick_la-unix_port.o magick/.libs/libGraphicsMagick_la-utility.o magick/.libs/libGraphicsMagick_la-version.o   -L/opt/obj/pkg/graphics/GraphicsMagick/work/.buildlink/lib /opt/obj/pkg/graphics/GraphicsMagick/work/.buildlink/lib/liblcms2.dylib /opt/obj/pkg/graphics/GraphicsMagick/work/.buildlink/lib/libfreetype.dylib /opt/obj/pkg/graphics/GraphicsMagick/work/.buildlink/lib/libpng16.dylib -lbrotlidec -lbz2 -lz /opt/obj/pkg/graphics/GraphicsMagick/work/.buildlink/lib/libltdl.dylib -lm -lpthread  -O2   -pthread -framework Carbon -install_name  /opt/pkg/lib/libGraphicsMagick.3.dylib -compatibility_version 28 -current_version 28.2 -Wl,-exported_symbols_list,magick/.libs/libGraphicsMagick-symbols.expsym
ld: library 'brotlidec' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[1]: *** [Makefile:6197: magick/libGraphicsMagick.la] Error 1
[...]

>How-To-Repeat:

Build graphics/GraphicsMagick with default options.

>Fix:

Patch Makefile to include buildlink support for archivers/brotli before freetype2 buildlink include.

--- Makefile    2023-11-11 10:47:55
+++ Makefile.new        2023-11-11 10:48:14
@@ -34,6 +34,7 @@
 .include "../../archivers/xz/buildlink3.mk"
 .include "../../devel/libltdl/buildlink3.mk"
 .include "../../devel/zlib/buildlink3.mk"
+.include "../../archivers/brotli/buildlink3.mk"
 .include "../../graphics/freetype2/buildlink3.mk"
 .include "../../graphics/jbigkit/buildlink3.mk"
 .include "../../mk/jpeg.buildlink3.mk"