[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/57074: sysutils/pv fails to build on modern MacOS, tries to use stat64
The following reply was made to PR pkg/57074; it has been noted by GNATS.
From: David Holland <dholland-pbugs%netbsd.org@localhost>
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost,
Subject: Re: pkg/57074: sysutils/pv fails to build on modern MacOS, tries to
Date: Tue, 9 May 2023 21:22:24 +0000
On Thu, Oct 27, 2022 at 11:05:01PM +0000, dns%strangeloop.cc@localhost wrote:
> I could not easily get around the detection of HAVE_STAT64 (autoconf
> defines this from successful compilation of function stat64(2)) but by
> using this "64_BIT_NODE" macro, defined on modern (Mac OSX 10.5 or
> higher) systems, this will ignore HAVE_STAT64 and fallback to the
> default behaviour of other OS's, which is to "define stat64 stat" and
> hence fix the code.
I think if we can't get the configure test to generate the right
answer we're better off suppressing it directly rather than using a
different and only semi-related predefined symbol (which might change
in the future) to avoid using the results.
So I think I'll go with the original makefile change we can reexamine
later if necessary.
(sorry it took six months to respond)
David A. Holland
Main Index |
Thread Index |