Re: pkg/57070 multimedia/handbrake doesn't build

[Iain Hibbert <plunky%ogmig.net@localhost>]

The following reply was made to PR pkg/57070; it has been noted by GNATS.

From: Iain Hibbert <plunky%ogmig.net@localhost>
To: john%ziaspace.com@localhost
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: pkg/57070 multimedia/handbrake doesn't build
Date: Sat, 8 Apr 2023 12:44:50 +0100 (BST)

 Hello
 
 This failure is because handbrake requires libjpeg-turbo and the 
 jpeg.buildlink3.mk file does not select it correctly:
 
 % cd /usr/pkgsrc/multimedia/handbrake
 % make -V '${JPEG_DEFAULT}' -V '${JPEG_ACCEPTED}' -V '${JPEG_TYPE}'
 jpeg
 libjpeg-turbo
 jpeg
 %
 
 This I guessed was because the tiff buildlink3.mk file has already 
 included jpeg.buildlink3.mk before JPEG_ACCEPTED is set. However, setting 
 that explicitly still does not work:
 
 % make JPEG_ACCEPTED=libjpeg-turbo -V '${JPEG_DEFAULT}' -V '${JPEG_ACCEPTED}' -V '${JPEG_TYPE}'
 jpeg
 libjpeg-turbo
 none
 %
 
 So there are cascading failures here which I did not follow as I see that 
 it cannot work anyway, as graphics/jpeg and graphics/libjpeg-turbo are 
 conflicting, so in fact a package cannot really define JPEG_ACCEPTED until 
 the conflict is overcome.
 
 (multimedia/handbrake is the only package which defines JPEG_ACCEPTED)
 
 Adding JPEG_DEFAULT=libjpeg-turbo to /etc/mk.conf will allow handbrake to 
 build successfully. However, you may need to rebuild all your packages in 
 that case.
 
 I have not looked in detail but see that handbrake internally has a 
 libjpeg-turbo module, which is possibly built as static and linked right 
 in, perhaps that would be a better solution
 
 regards,
 iain