pkg/57159: davical requiring tuning and and version upgrade

[br0nko%protonmail.com@localhost]

>Number:         57159
>Category:       pkg
>Synopsis:       davical requiring tuning and and version upgrade
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 04 14:35:00 +0000 2023
>Originator:     br0nko
>Release:        2022Q4
>Organization:
>Environment:
NetBSD n10.domain.internal 10.0_BETA NetBSD 10.0_BETA (GENERIC) #0: Sat Dec 31 04:55:53 UTC 2022  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64
>Description:
davical require several config tweaks and version upgrade to be fully functional (php8):

1/ apache setup provided in /usr/pkg/etc/davical/davical.conf need to be updated for apache 2.4 access control directive:

--- davical.conf.ori	2023-01-04 12:26:46.905846358 +0000
+++ davical.conf	2023-01-04 14:09:03.223599890 +0000
@@ -5,8 +5,7 @@
 <Directory "/usr/pkg/share/davical/htdocs">
 	AllowOverride All
 	DirectoryIndex index.php
-	Order Allow,Deny
-	Allow from All
+	Require all granted
 	php_value include_path "/usr/pkg/lib/php/awl"
 </Directory>

@@ -22,8 +21,7 @@
 #	DirectoryIndex index.php
 #
 #	<Location />
-#		Order allow,deny
-#		Allow from all
+#		Require all granted
 #	</Location>
 #
 #	php_value include_path "/usr/pkg/lib/php/awl"

2/ /usr/pkg/etc/davical/config.php permissions need to be adjusted
With a setup using unix socket, I was getting the following error while accessing davical home page:

[Wed Jan 04 13:25:23.804274 2023] [php:warn] [pid 1752] [client 192.168.1.45:63507] PHP Warning:  include(): Failed opening '/usr/pkg/etc/davical/config.php' for inclusion (include_path='../inc:/usr/pkg/lib/php/awl/inc:/usr/pkg/lib/php/awl') in /usr/pkg/share/davical/htdocs/always.php on line 211
[Wed Jan 04 13:25:23.809626 2023] [php:warn] [pid 1752] [client 192.168.1.45:63507] PHP Warning:  Undefined variable $connection_strings in /usr/pkg/lib/php/awl/inc/AwlQuery.php on line 55
[Wed Jan 04 13:25:23.809648 2023] [php:warn] [pid 1752] [client 192.168.1.45:63507] PHP Warning:  foreach() argument must be of type array|object, null given in /usr/pkg/lib/php/awl/inc/AwlQuery.php on line 55

Appears to be a file permission issue:

-rw-r-----  1 root  wheel  33027 Jan  4 12:26 config.php

Changing group permission to www did the trick (might not be the best approach)

-rw-r-----  1 root  www    33027 Jan  4 13:35 config.php

3/ Davical setup page is broken

Exception [0] Call to undefined function get_magic_quotes_gpc()
At line 154 of /usr/pkg/share/davical/htdocs/setup.php
================= Stack Trace ===================
/usr/pkg/share/davical/htdocs/setup.php[390] build_dependencies_table()
/usr/pkg/share/davical/htdocs/setup.php[359] check_magic_quotes_gpc()

This is a bug due to deprecated get_magic_quotes* function call, fixed in davical 1.1.11:
https://gitlab.com/davical-project/davical/-/issues/234
https://wiki.davical.org/index.php/Release_Notes/1.1.11

4/ Tools page also broken

Exception [0] Call to undefined function each()
At line 486 of /usr/pkg/lib/php/awl/inc/DataEntry.php
================= Stack Trace ===================
/usr/pkg/share/davical/htdocs/tools.php[165] Tools->render()
/usr/pkg/share/davical/htdocs/tools.php[43] Tools::renderImportFromDirectory()
/usr/pkg/share/davical/htdocs/tools.php[85] EntryForm->StartForm()

This time a bug in AWL with php8, fixed starting 0.62 (probably better to upgrade to 0.63, as there's others php8.1 fixes ):
https://gitlab.com/davical-project/awl/-/commit/0adab0ac9a939196bee96f30ff6bc1e00eff3edb


>How-To-Repeat:
do the default install (unix socket / apache) 
>Fix:
see Full description