pkg/57062: master is not a valid tag name, use an explicit commit hash

[andrew.cagney%gmail.com@localhost]

>Number:         57062
>Category:       pkg
>Synopsis:       master is not a valid tag name, use an explicit commit hash
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 17 15:40:01 +0000 2022
>Originator:     cagney
>Release:        pkgsrc-2022Q3
>Organization:
>Environment:
NetBSD arm64 9.2_STABLE NetBSD 9.2_STABLE 
>Description:
The file mk/fetch/github.mk contains the check:

.  if !empty(GITHUB_TAG:Mmaster)
PKG_FAIL_REASON+=       "master is not a valid tag name, use an explicit commit hash"
.  endif

It should be updated, or perhaps replaced by documentation explaining that it really needs to be a "tag" (hence the suffix) and not a branch.

(I suspect adding GITHUB_TAG=main NO_CHECKSUM=yes to the package Makefile is frowned upon)


>How-To-Repeat:
make GITHUB_TAG=main

>Fix: