pkg/56871: textproc/rarian's rarian-sk-update always outputs strange usage

[oshima-ya%yagoto-urayama.jp@localhost]

>Number:         56871
>Category:       pkg
>Synopsis:       textproc/rarian's rarian-sk-update always outputs strange usage
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 08 10:50:00 +0000 2022
>Originator:     Yasushi Oshima
>Release:        pkgsrc-current
>Organization:
none
>Environment:
NetBSD sudachi 9.2_STABLE NetBSD 9.2_STABLE (GENERIC) #0: Wed Jun  8 03:47:42 JST 2022  oshima@sudachi:/export/netbsd-9/20220520/obj/amd64/sys/arch/amd64/compile/GENERIC amd64
>Description:
textproc/rarian rarian-sk-update and its symlink scrollkeeper-update always output strange usage messages.
for example:
-----------
$ rarian-sk-update
getopt: unknown option -- n
getopt: unknown option -- r
getopt: unknown option -- a
getopt: unknown option -- r
getopt: unknown option -- i
getopt: unknown option -- a
getopt: unknown option -- n
getopt: unknown option -- s
getopt: unknown option -- k
getopt: unknown option -- p
getopt: unknown option -- d
getopt: unknown option -- a
getopt: unknown option -- t
getopt: unknown option -- e
getopt: unknown option -- o
Usage: rarian-sk-update [OPTIONS]
Update Rarian scrolls archive from scrollkeeper omf files.
Note: This script is a replacement for scrollkeeper-update, but
does not update the scrollkeeper internal database.

Options:
-o DIR                          Use the specified omf directories for
                                conversion. Multiple directories can be
                                specified using colon (:) separator.
-r DIR                          Use the specified directory for the resulting
                                scrolls.  If the directory doesn't exist, it
                                will be created at run time.
                                 Note: Multiple output paths are not supported
--c                             Rebuild the index entirely.  This will rebuild
                                all scroll files and may take a long time.
-v                              Turn Verbosity on.
-p                              Specify a different place to store the mtimes file.
-q                              Run silently (default).
-h, -?                          Print this help message and exit.

Using this script without option will use the default omf directory
'/usr/pkg/share/omf' and the default output directory '/usr/pkg/share/help'

NOTE (2): This script doesn't do anything and is　　
only provided for scrollkeeper compatibility
-------
scropllkeeper-update is used by some pkgsrc install/deinstall scripts, so it  occurs when run pkg_add/pkg_delete.

For example, add package graphics/dia:
-----
# pkg_add dia
 pkg_add dia
getopt: unknown option -- n
getopt: unknown option -- s
getopt: unknown option -- c
getopt: unknown option -- r
getopt: unknown option -- o
getopt: unknown option -- l
getopt: unknown option -- l
getopt: unknown option -- k
getopt: unknown option -- e
getopt: unknown option -- e
getopt: unknown option -- p
getopt: unknown option -- e
getopt: unknown option -- r
getopt: unknown option -- p
getopt: unknown option -- d
getopt: unknown option -- a
getopt: unknown option -- t
getopt: unknown option -- e
getopt: unknown option -- o
Usage: scrollkeeper-update [OPTIONS]
Update Rarian scrolls archive from scrollkeeper omf files.
Note: This script is a replacement for scrollkeeper-update, but
does not update the scrollkeeper internal database.

Options:
-o DIR                          Use the specified omf directories for
                                conversion. Multiple directories can be
                                specified using colon (:) separator.
-r DIR                          Use the specified directory for the resulting
                                scrolls.  If the directory doesn't exist, it
                                will be created at run time.
                                 Note: Multiple output paths are not supported
--c                             Rebuild the index entirely.  This will rebuild
                                all scroll files and may take a long time.
-v                              Turn Verbosity on.
-p                              Specify a different place to store the mtimes file.
-q                              Run silently (default).
-h, -?                          Print this help message and exit.

Using this script without option will use the default omf directory
'/usr/pkg/share/omf' and the default output directory '/usr/pkg/share/help'

NOTE (2): This script doesn't do anything and is
only provided for scrollkeeper compatibility
#
-----
>How-To-Repeat:
- pkg_add rarian and run form shell rarian-sk-update or scrollkeeper-update  

or 

- pkg_add dia binary package
 
>Fix:
This is because  "rarian-sk-update" uses flags '-n' which is not supported by NetBSD's getopt(1)。 
And this occurs after the change at 2019/9/12;
 -  http://mail-index.netbsd.org/pkgsrc-changes/2019/09/12/msg197418.html
This removed patch-aa uses pkgsrc/misc/getopt instead of system's getopt.
When I change to use pkgsrc's getopt as same as old patch-aa, this problem will fix.