Re: pkg/32807: tkdesk segfaults on startup

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/32807; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/32807: tkdesk segfaults on startup
Date: Mon, 6 Jun 2022 05:33:23 +0000

 On Mon, Jun 06, 2022 at 05:15:02AM +0000, David A. Holland wrote:
  >  Fix up sysutils/tkdesk, some.
  >  
  >   - Fix up the TCL interpreter result handling so we don't need to use
  >     USE_INTERP_RESULT.
  >  
  >   - Fix the first startup segfault (probably the one seen in PR 32807
  >     but not necessarily) by using Tcl_Free instead of trying to bypass
  >     it. Unfortunately, there's at least one more segfault at startup
  >     with no obvious cause.
 
 That is: even with these fixes, it still segfaults on startup. The
 current crash is in XPM handling and has no obvious cause, but might
 be found with a debug build and more knowledge of what's supposed to
 be happening.
 
 Other avenues of attack: x11/blt still generates a ton of build
 warnings and does a bunch of unsafe things (hidden by floods of noise
 messages because it likes to stuff integers in pointers) -- cleaning
 it up to pass -Wall may help.
 
 tkdesk also probably doesn't pass -Wall, and sometimes the warnings
 that come up that way are real problems.
 
 Given that this package has apparently been inoperable for 16 years,
 and blt has been inoperable for some years too (even though other
 things use it) probably nobody's using any of this stuff and maybe it
 should be cleared out? It isn't obvious that it's useless or
 hopelessly dated though.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost