Re: pkg/56519: zsh fails to build on Solaris 10

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/56519; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/56519: zsh fails to build on Solaris 10
Date: Sun, 22 May 2022 23:43:38 +0000

 On Tue, Nov 23, 2021 at 07:55:00PM +0000, pekdon%gmail.com@localhost wrote:
  > >Description:
  > Compiling zsh fails on Solaris 10 due to checks in configure not
  > detecting the presence of sigset_t (and others).
  > 
  > From the config.log:
  > 
  > sts.h:346:2: error: #error "Compiler or options invalid for pre-UNIX 03 X/Open applications     and pre-2001 POSIX applications"
  >  #error "Compiler or options invalid for pre-UNIX 03 X/Open applications \
  >   ^~~~~
  > [...]
  > +-[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#define _POSIX_C_SOURCE 200809L
  > ++[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#ifndef __sun
  > ++#  define _POSIX_C_SOURCE 200809L
  > ++#endif
 
 Wouldn't it be better to pass whatever CFLAGS are needed to be allowed
 to set _POSIX_C_SOURCE as upstream wants?
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost