Re: pkg/56684: mail/elm build fails on NetBSD/sparc-9.99.93

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/56684; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: "John D. Baker" <jdbaker%consolidated.net@localhost>
Subject: Re: pkg/56684: mail/elm build fails on NetBSD/sparc-9.99.93
Date: Sun, 15 May 2022 05:33:44 +0000

 On Sun, May 15, 2022 at 05:10:01AM +0000, David Holland wrote:
  >  This is a base bug. libcrypt.a shouldn't pollute the linker namespace
  >  with something called "initialize".
  >  
  >  Seems to come from the argon2 code...
 
 I filed lib/56838 on this.
 
 It turns out it only affects the static libcrypt (it plays ELF
 visibility games, which only affect the shared library image) so the
 following should serve as a workaround.
 
 I'm going to leave this PR open until it becomes clear whether this
 is going to be broken in -10 or not, in which case we'll need the
 workaround in pkgsrc.
 
 Although maybe it's a good change to have anyway, since the only
 reason elm is using the static libcrypt is that its configury is from
 about 1994. :-|
 
 
 (do you really still use elm? I held out for a long time but gave up
 and switched to mutt some time ago... if you do, I might go tidy all
 the build warnings)
 
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mail/elm/Makefile,v
 retrieving revision 1.52
 diff -u -r1.52 Makefile
 --- Makefile	19 Aug 2017 00:20:25 -0000	1.52
 +++ Makefile	15 May 2022 05:28:29 -0000
 @@ -29,6 +29,13 @@
  LIBC.Darwin=		/usr/lib/libSystem.dylib
  LIBC.*=			/usr/lib/libc.so
  
 +# Workaround for PR 56684: avoid explicit static linkage of libcrypt
 +SUBST_CLASSES+=		libcrypt
 +SUBST_SED.libcrypt=	-e 's,/usr/lib/libcrypt.a,-lcrypt,'
 +SUBST_STAGE.libcrypt=	post-configure
 +SUBST_FILES.libcrypt=	Make.defs lib/Makefile src/Makefile utils/Makefile
 +SUBST_MESSAGE.libcrypt=	Avoiding static linkage of libcrypt
 +
  SPECIAL_PERMS+=		bin/elm ${REAL_ROOT_USER} mail 2755
  
  pre-configure:
 
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost