Re: pkg/56733: mtree bug processing filenames containing asterisks

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/56733; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/56733: mtree bug processing filenames containing asterisks
Date: Thu, 21 Apr 2022 02:58:27 +0000

 Not sent to gnats.
 (All bug database traffic should be sent to gnats-bugs@. This usually
 doesn't happen automatically if you reply to yourself.)
 
    ------
 
 From: John Goerzen <jgoerzen%complete.org@localhost>
 To: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost, jgoerzen%complete.org@localhost
 Subject: Re: pkg/56733: mtree bug processing filenames containing asterisks
 Date: Tue, 01 Mar 2022 09:47:31 -0600
 
 FWIW, I just realized that there are two different mtree trees in
 NetBSD; one in pkgsrc, and one in src/usr.sbin.
 
 I have been using the one from pkgsrc, and was asked to submit here.
 The trees are related but divergent.
 
 This patch fixes the issue for me with the pkgsrc tree:
 
 --- verify.c.orig       2018-08-22 15:48:38.000000000 -0500
 +++ verify.c    2022-03-01 09:45:04.854574448 -0600
 @@ -142,9 +142,7 @@
                 if (specdepth != p->fts_level)
                         goto extra;
                 for (ep = level; ep; ep = ep->next)
 -                       if ((ep->flags & F_MAGIC &&
 -                           !fnmatch(ep->name, p->fts_name, FNM_PATHNAME)) ||
 -                           !strcmp(ep->name, p->fts_name)) {
 +                       if (!strcmp(ep->name, p->fts_name)) {
                                 ep->flags |= F_VISIT;
                                 if (compare(ep, p))
                                         rval = MISMATCHEXIT;
 
 - John
 
 
 From: John Goerzen <jgoerzen%complete.org@localhost>
 To: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost, jgoerzen%complete.org@localhost
 Subject: Re: pkg/56733: mtree bug processing filenames containing asterisks
 Date: Tue, 01 Mar 2022 09:57:03 -0600
 
 I should add -- from what I can see, the bug exists in the same way in
 the usr.sbin tree and this fix ought to apply there as well.
 
 John