pkg/56723: x11/xscreensaver 6.02 fails to build on NetBSD 9.x

[david%gutteridge.ca@localhost]

>Number:         56723
>Category:       pkg
>Synopsis:       x11/xscreensaver 6.02 fails to build on NetBSD 9.x
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 19 02:20:00 +0000 2022
>Originator:     David H. Gutteridge
>Release:        pkgsrc -current with NetBSD 9.2_STABLE
>Organization:
TNF
>Environment:
NetBSD arcusxvii.nonus-porta.net 9.2_STABLE NetBSD 9.2_STABLE (GENERIC) #0: Thu Dec 30 12:40:08 UTC 2021  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64
>Description:
Since the update to 6.02, xscreensaver fails to build on NetBSD
9.2_STABLE like so:

gcc -std=gnu89 -pedantic -Wall -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wdeclaration-after-statement -Wno-overlength-strings -Wno-language-extension-token -Wno-variadic-macros -c -I. -I. -I./../utils -I..  -I/usr/pkg/include/gtk-2.0 -I/usr/pkg/lib/gtk-2.0/include -I/usr/pkg/include/pango-1.0 -I/usr/pkg/include -I/usr/pkg/include/glib-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/harfbuzz -I/usr/X11R7/include/freetype2 -I/usr/pkg/include/fribidi -I/usr/X11R7/include -I/usr/pkg/include/cairo -I/usr/X11R7/include/pixman-1 -I/usr/pkg/include/libpng16 -D_REENTRANT -D_REENTRANT -D_REENTRANT -D_REENTRANT -I/usr/pkg/include/gio-unix-2.0 -D_REENTRANT -I/usr/pkg/include/gdk-pixbuf-2.0 -D_REENTRANT -I/usr/pkg/include/atk-1.0 -D_REENTRANT -D_REENTRANT -I/usr/pkg/include/libxml2 -pthread -D_REENTRANT  -I/usr/pkg/include/gdk-pixbuf-2.0 -I/usr/pkg/include -I/usr/pkg/include/glib-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/libpng16 -I/usr/X11R7/include -D_REENTR
 ANT -pthread  -I/usr/X11R7/include -D_REENTRANT -I/usr/X11R7/include/freetype2  -DSTANDALONE -DHAVE_CONFIG_H -DNO_STATIC_MODULES -DNO_STATIC_MODULES -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -I/usr/pkg/include/harfbuzz -O2 -fPIC -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -DNO_STATIC_MODULES -DNO_STATIC_MODULES -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -I/usr/pkg/include/harfbuzz -I/usr/pkg/include -I/usr/pkg/include  -I/usr/X11R7/include marbling.c
marbling.c:159:33: error: initializer element is not constant
 const unsigned noise_out_bits = noise_work_bits - 3 * lerp_loss + 1;
                                 ^~~~~~~~~~~~~~~
cc1: warning: unrecognized command line option '-Wno-language-extension-token'
gmake[1]: *** [Makefile:504: marbling.o] Error 1

This seems to be a compiler bug, as technically noise_work_bits and
lerp_loss are constants. Evidently, GCC 10 doesn't take issue with
this, given the same arguments, since it does build on NetBSD 9.99.93.

One option is to patch the code to avoid this particular construct. I
don't know if there are more potential issues like this one, or if this
is unique. Another option is to require a newer GCC, but I'm not a fan
of that choice here for more than one reason. (I did try forcing other
arguments to GCC, e.g., "gnu99" instead of "gnu89", but that made no
difference.)

(This breakage of course means various DE meta packages like xfce4 and
lxqt are also broken.)

>How-To-Repeat:
As above. Attempt to build the package.
>Fix:
See above.