pkg/56698: libffi requires readelf to build correctly on Solaris 10

[pekdon%gmail.com@localhost]

>Number:         56698
>Category:       pkg
>Synopsis:       libffi requires readelf to build correctly on Solaris 10
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 07 07:30:01 +0000 2022
>Originator:     Claes Nästén
>Release:        trunk 2022-02-07
>Organization:
>Environment:
SunOS 5.10 sun4v sparc SUNW,SPARC-Enterprise-T2000
>Description:
Building libffi on Solaris 10 stock GCC fails with an error like:

eh_frame have incompatibile attributes and cannot be merged into a single output section

This is because it fails to detect whether or not the eh_frame should be read only it seems.

Snippets from the configure.ac file:

....

AC_CHECK_TOOL(READELF, readelf)

....

            if $READELF -WS conftest.o | grep -q -n 'eh_frame .* WA'; then
                libffi_cv_ro_eh_frame=no
            fi

Configure logs and error:

checking whether .eh_frame section should be read-only... .././configure[18812]: -WS: inaccessible or not found.
>How-To-Repeat:
Build libffi on Solaris 10 as part of bootstrapping GCC (Python3 drags in the dependency)
>Fix:
--- a/devel/libffi/Makefile
+++ b/devel/libffi/Makefile
@@ -13,7 +13,7 @@ LICENSE=      mit
 
 USE_LANGUAGES=         c c++
 USE_LIBTOOL=           yes
-USE_TOOLS+=                gmake pkg-config
+USE_TOOLS+=          gmake pkg-config readelf
 USE_TOOLS.SunOS+=      perl
 GNU_CONFIGURE=         yes
 CONFIGURE_ARGS+=       --disable-multi-os-directory