pkg/56633: ffmpeg4 fails to build on Solaris 10

[pekdon%gmail.com@localhost]

>Number:         56633
>Category:       pkg
>Synopsis:       ffmpeg4 fails to build on Solaris 10
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 16 19:45:00 +0000 2022
>Originator:     Claes Nästén
>Release:        trunk 2022-01-01
>Organization:
>Environment:
SunOS 5.10 i86pc i386 i86pc
>Description:
Building ffmpeg4 fails on Solaris 10, due to missing -lrt AND if using mksh as shell the version setup fails causing .so. files to be created instead of .so.X.X.X
>How-To-Repeat:
Build ffmpeg4 on Solaris 10.
>Fix:
Diff:

--- a/multimedia/ffmpeg4/Makefile.common
+++ b/multimedia/ffmpeg4/Makefile.common
@@ -32,6 +32,7 @@ CONFIGURE_ARGS+=      --incdir=${PREFIX}/include/ffmpeg4
 CONFIGURE_ARGS+=       --libdir=${PREFIX}/lib/ffmpeg4
 CONFIGURE_ARGS+=       --shlibdir=${PREFIX}/lib/ffmpeg4
 LDFLAGS+=              ${COMPILER_RPATH_FLAG}${PREFIX}/lib/ffmpeg4
+LDFLAGS.SunOS+=                -lrt
 
 .if !empty(MACHINE_PLATFORM:MDarwin-1[2-9].*-*) || !empty(MACHINE_PLATFORM:MDarwin-2*)
 CONFIGURE_ARGS+=       --enable-opencl
@@ -73,6 +74,7 @@ REPLACE_PERL+=        doc/texi2pod.pl
 REPLACE_SH+=   configure
 REPLACE_SH+=   ffbuild/pkgconfig_generate.sh
 REPLACE_SH+=   ffbuild/version.sh
+REPLACE_SH+=   ffbuild/libversion.sh
 
 PLIST_SRC+=    ${PKGDIR}/PLIST
 

And the file patches/patch-ffbuild_libversion.sh

$NetBSD$

--- ffbuild/libversion.sh.orig  2021-10-21 17:06:35.000000000 +0000
+++ ffbuild/libversion.sh
@@ -1,3 +1,5 @@
+#!/bin/sh
+
 toupper(){
     echo "$@" | tr abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ
 }