Re: pkg/56604: www/webkit-gtk 2.34.3 fails to build on NetBSD 9.x stable branches

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello David!

david%gutteridge.ca@localhost writes:
> [...]
> Attempting to build www/webkit-gtk 2.34.3 (as currently defined for
> both pkgsrc 2021Q4 and -current) on NetBSD 9.x stable branches fails.
>
> An example can be found here:
> http://victory.netbsd.org/pkgsrc/packages/reports/2021Q4/amd64-9.0/20220103.0714/webkit-gtk-2.34.3nb1/build.log
>
> It fails like so:
>
> [ 20%] Linking CXX executable ../../bin/WebKitWebDriver
> ld: CMakeFiles/WebDriver.dir/Session.cpp.o: in function `WebDriver::Session::setInputFileUploadFiles(WTF::String const&, WTF::String const&, bool, WTF::Function<void (WebDriver::CommandRes
ult&&)>&&)':
> Session.cpp:(.text+0x180f3): undefined reference to `WTF::FileSystemImpl::fileExists(WTF::String const&)'
> gmake[2]: *** [Source/WebDriver/CMakeFiles/WebDriver.dir/build.make:281: bin/WebKitWebDriver] Error 1
> gmake[1]: *** [CMakeFiles/Makefile2:1615: Source/WebDriver/CMakeFiles/WebDriver.dir/all] Error 2
> gmake[1]: *** Waiting for unfinished jobs....
> [ 20%] Building CXX object Source/JavaScriptCore/CMa
>
> I can reproduce this in my own build environment running 9.2_STABLE. (I
> can, however, successfully build this package on 9.99.93 as of last
> week.)
> [...]

I think that unfortunately this is because it depends on <filesystem>
and/or <experimental/filesystem>:

In netbsd-9, e.g.:

 http://victory.netbsd.org/pkgsrc/packages/reports/2021Q4/amd64-9.0/20220103.0714/webkit-gtk-2.34.3nb1/configure.log

It seems that we see:

 -- Performing Test STD_FILESYSTEM_IS_AVAILABLE
 -- Performing Test STD_FILESYSTEM_IS_AVAILABLE - Failed
 -- Performing Test STD_EXPERIMENTAL_FILESYSTEM_IS_AVAILABLE
 -- Performing Test STD_EXPERIMENTAL_FILESYSTEM_IS_AVAILABLE - Failed

...while on -current-ish (9.99.90):

 -- Performing Test STD_FILESYSTEM_IS_AVAILABLE
 -- Performing Test STD_FILESYSTEM_IS_AVAILABLE - Success

...and I think that's probably why it fails in netbsd-9.

I have no idea how we can possibly address that thogh and I have not
investigated further.