pkg/56553: "pkg_add firefox" doesn't install pciutils

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         56553
>Category:       pkg
>Synopsis:       "pkg_add firefox" doesn't install pciutils
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 19 09:35:00 +0000 2021
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.2
>Organization:
>Environment:
System: NetBSD optiplex 9.2 NetBSD 9.2 (GENERIC) #0: Wed May 12 13:15:55 UTC 2021  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
Recently pkgsrc/www/firefox has been changed to pull pciutils,
 https://mail-index.netbsd.org/pkgsrc-changes/2021/12/17/msg245287.html
but "pkg_add firefox" doesn't install pciutils.

>How-To-Repeat:
Build and pkg_add firefox.

>Fix:
pkgsrc/sysutils/pciutils/buildlink3.mk has
"BUILDLINK_DEPMETHOD.pciutils?= build"
by default, so maybe all applications that require libpci.so
should have
BUILDLINK_DEPMETHOD.pciutils+= full
line?

Additionally, it would be better to sort all buildlink3.mk
in current mozilla-common.mk.

---
Index: mozilla-common.mk
===================================================================
RCS file: /cvsroot/pkgsrc/www/firefox/mozilla-common.mk,v
retrieving revision 1.213
diff -u -p -d -r1.213 mozilla-common.mk
--- mozilla-common.mk	17 Dec 2021 20:08:42 -0000	1.213
+++ mozilla-common.mk	19 Dec 2021 09:02:54 -0000
@@ -181,14 +181,12 @@ CONFIGURE_ENV.NetBSD+=	ac_cv_thread_keyw
 # In unspecified case, clock_gettime(CLOCK_MONOTONIC, ...) fails.
 CONFIGURE_ENV.NetBSD+=	ac_cv_clock_monotonic=
 
-.include "../../sysutils/pciutils/buildlink3.mk"
 .include "../../mk/atomic64.mk"
 BUILDLINK_API_DEPENDS.libevent+=	libevent>=1.1
 .include "../../devel/libevent/buildlink3.mk"
 .include "../../devel/libffi/buildlink3.mk"
 BUILDLINK_API_DEPENDS.nspr+=	nspr>=4.32
 .include "../../devel/nspr/buildlink3.mk"
-.include "../../textproc/icu/buildlink3.mk"
 BUILDLINK_API_DEPENDS.nss+=	nss>=3.71
 .include "../../devel/nss/buildlink3.mk"
 .include "../../devel/zlib/buildlink3.mk"
@@ -202,13 +200,16 @@ BUILDLINK_DEPMETHOD.clang=	build
 .include "../../lang/clang/buildlink3.mk"
 RUST_REQ=	1.53.0
 .include "../../lang/rust/rust.mk"
+.include "../../multimedia/ffmpeg4/buildlink3.mk"
 # webrtc option requires internal libvpx
 #BUILDLINK_API_DEPENDS.libvpx+=	libvpx>=1.3.0
 #.include "../../multimedia/libvpx/buildlink3.mk"
 .include "../../net/libIDL/buildlink3.mk"
+BUILDLINK_DEPMETHOD.pciutils+=		full
+.include "../../sysutils/pciutils/buildlink3.mk"
 # textproc/hunspell 1.3 is too old
 #.include "../../textproc/hunspell/buildlink3.mk"
-.include "../../multimedia/ffmpeg4/buildlink3.mk"
+.include "../../textproc/icu/buildlink3.mk"
 .include "../../x11/libXt/buildlink3.mk"
 BUILDLINK_API_DEPENDS.pixman+= pixman>=0.25.2
 .include "../../x11/pixman/buildlink3.mk"

---
Izumi Tsutsui