pkg/56537: jemalloc fails to build on Solaris 10

[pekdon%gmail.com@localhost]

>Number:         56537
>Category:       pkg
>Synopsis:       jemalloc fails to build on Solaris 10
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 05 11:15:00 +0000 2021
>Originator:     Claes Nästén
>Release:        trunk 2021-12-03
>Organization:
>Environment:
SunOS 5.10 i86pc i386 i86pc

>Description:
Building jemalloc failed with the following error:
>How-To-Repeat:
Build jemalloc on Solaris 10
>Fix:
Looking at the top level Makefile.in it sets the shell:

SHELL := /bin/sh

This is turn seems to lead to a generated file not being generated.

Just changing SHELL := /bin/sh to SHELL ?= /bin/sh resolved the issue for me.

--- a/devel/jemalloc/patches/patch-Makefile.in
+++ b/devel/jemalloc/patches/patch-Makefile.in
@@ -2,9 +2,18 @@ $NetBSD: patch-Makefile.in,v 1.2 2016/12/13 21:52:22 maya Exp $
 
 Fix permissions of installed static libraries.
 
---- Makefile.in.orig   2016-11-16 22:15:43.000000000 +0100
-+++ Makefile.in        2016-11-16 22:17:04.000000000 +0100
-@@ -348,8 +348,8 @@
+--- Makefile.in.orig   2019-08-05 20:02:00.000000000 +0000
++++ Makefile.in
+@@ -6,7 +6,7 @@ vpath % .
+ # Clear the default suffixes, so that built-in rules are not used.
+ .SUFFIXES :
+ 
+-SHELL := /bin/sh
++SHELL ?= /bin/sh
+ 
+ CC := @CC@
+ CXX := @CXX@
+@@ -482,8 +482,8 @@ endif
  install_lib_static: $(STATIC_LIBS)
        $(INSTALL) -d $(LIBDIR)
        @for l in $(STATIC_LIBS); do \