pkg/56509: gstreamer1 build issues on Solaris (and SmartOS) after upgrade to 1.18.5

[pekdon%gmail.com@localhost]

>Number:         56509
>Category:       pkg
>Synopsis:       gstreamer1 build issues on Solaris (and SmartOS) after upgrade to 1.18.5
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 18 19:25:00 +0000 2021
>Originator:     Claes Nästén
>Release:        trunk 2021-11-17
>Organization:
>Environment:
SunOS 5.10 i86pc i386 i86pc
>Description:
A few gstreamer1 build issues popped up after the upgrade to 1.18.5, seen on Solaris 10 and some on SmartOS bulk builds as well.

gstreamer1

Undefined                       first referenced
 symbol                             in file
socketpair                          gst/libgstreamer-1.0.so.0.1805.0.p/gstpoll.c.o  (symbol belongs to implicit dependency /lib/amd64/libso$
ket.so.1)
ld: fatal: symbol referencing errors. No output written to gst/libgstreamer-1.0.so.0.1805.0
collect2: error: ld returned 1 exit status

AND

[202/512] Linking target plugins/tracers/libgstcoretracers.so
FAILED: plugins/tracers/libgstcoretracers.so
gcc  -o plugins/tracers/libgstcoretracers.so plugins/tracers/libgstcoretracers.so.p/gstlatency.c.o plugins/tracers/libgstcoretracers.so.p/gstleaks.c.o plugins/tracers/libgstcoretracers.so.p/gststats.c.o plugins/tracers/libgstcoretracers.so.p/gsttracers.c.o plugins/tracers/libgstcoretracers.so.p/gstlog.c.o plugins/tracers/libgstcoretracers.so.p/gstrusage.c.o -L/usr/pkg/gcc8/lib/gcc/x86_64-sun-solaris2.10/8.4.0 -L/usr/pkg/gcc8/lib/amd64 -L/usr/pkg/lib -L/usr/lib/amd64 -I/usr/pkg/include -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/include -I/usr/pkg/include/python3.9 -z defs -shared -fPIC -Wl,--start-group -Wl,-soname,libgstcoretracers.so -lsocket -lnsl -Wl,-R/usr/pkg/gcc8/lib/gcc/x86_64-sun-solaris2.10/8.4.0 -Wl,-R/usr/pkg/gcc8/lib/amd64 -Wl,-R/usr/pkg/lib -Wl,-R/usr/lib/amd64 -O2 -D_FORTIFY_SOURCE=2 '-Wl,-rpath,$ORIGIN/../../gst' gst/libgstreamer-1.0.so.0.1805.0 -Wl,-R/usr/pkg/lib /usr/pkg/lib/libglib-2.0.so /usr/pkg/lib/libintl.s
 o /usr/pkg/lib/libgobject-2.0.so -Wl,-R/usr/pkg/lib /usr/pkg/lib/libgmodule-2.0.so -Wl,--end-group -Wl,-R/usr/pkg/lib
Undefined                       first referenced
 symbol                             in file
clock_gettime                       plugins/tracers/libgstcoretracers.so.p/gstrusage.c.o  (symbol belongs to implicit dependency /lib/amd64/librt.so.1)
ld: fatal: symbol referencing errors. No output written to plugins/tracers/libgstcoretracers.so
collect2: error: ld returned 1 exit status

gst-plugins1-base

[152/333] Linking target gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0
FAILED: gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0
gcc  -o gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0 gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0.p/meson-generated_.._gstrtsp-enumtypes.c.o
 gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0.p/gstrtsptransport.c.o gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0.p/gstrtspurl.c.o gst-libs/
gst/rtsp/libgstrtsp-1.0.so.0.1805.0.p/gstrtspmessage.c.o gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0.p/gstrtspconnection.c.o gst-libs/gst/r
tsp/libgstrtsp-1.0.so.0.1805.0.p/gstrtspdefs.c.o gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0.p/gstrtspextension.c.o gst-libs/gst/rtsp/libgs
trtsp-1.0.so.0.1805.0.p/gstrtsprange.c.o -L/usr/pkg/gcc8/lib/gcc/x86_64-sun-solaris2.10/8.4.0 -L/usr/pkg/gcc8/lib/amd64 -L/usr/lib/amd64 -L/
usr/pkg/lib -I/usr/include -I/usr/pkg/include -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -z
 defs -shared -fPIC -Wl,--start-group -Wl,-soname,libgstrtsp-1.0.so.0 -Wl,-R/usr/pkg/gcc8/lib/gcc/x86_64-sun-solaris2.10/8.4.0 -Wl,-R/usr/pk
g/gcc8/lib/amd64 -Wl,-R/usr/lib/amd64 -Wl,-R/usr/pkg/lib -O2 -D_FORTIFY_SOURCE=2 /usr/pkg/lib/libgstbase-1.0.so /usr/pkg/lib/libgstreamer-1.
0.so /usr/pkg/lib/libgobject-2.0.so -Wl,-R/usr/pkg/lib /usr/pkg/lib/libglib-2.0.so /usr/pkg/lib/libintl.so -Wl,-R/usr/pkg/lib /usr/pkg/lib/l
ibgio-2.0.so -Wl,-R/usr/pkg/lib -lm -Wl,--end-group
Undefined                       first referenced
 symbol                             in file
getsockname                         gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0.p/gstrtspconnection.c.o  (symbol belongs to implicit depend
ency /lib/amd64/libsocket.so.1)
setsockopt                          gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0.p/gstrtspconnection.c.o  (symbol belongs to implicit depend
ency /lib/amd64/libsocket.so.1)
ld: fatal: symbol referencing errors. No output written to gst-libs/gst/rtsp/libgstrtsp-1.0.so.0.1805.0
collect2: error: ld returned 1 exit status

In addition, gst/tcp/gstmultifdsink.c fails to compile due to undefined 
>How-To-Repeat:
Build multimedia/gstreamer1 or multimedia/gst-plugins1-base
>Fix:
multimedia/gstreamer1/Makefile

LDFLAGS.SunOS+= -lsocket -lnsl -lrt

multimedia/gst-plugins1-base/Makefile

LDFLAGS.SunOS+= -lsocket -lnsl

multimedia/gst-plugins1-base/patches/patch-gst_tcp_gstmultifdsink.c 

$NetBSD$

--- gst/tcp/gstmultifdsink.c.orig       2021-11-18 19:16:20.355525783 +0000
+++ gst/tcp/gstmultifdsink.c
@@ -121,6 +121,10 @@
 
 #include "gstmultifdsink.h"
 
+#if !defined(FIONREAD) && defined(__sun)
+#include <sys/filio.h>
+#endif
+
 #define NOT_IMPLEMENTED 0
 
 GST_DEBUG_CATEGORY_STATIC (multifdsink_debug);